In drupal_get_schema(), the parameter $name should IMHO be renamed to $table.

$name is confusing, as it could just as well represent the module name that is for example expected as parameter by drupal_install_schema($module).
But here it represents the table name, as in drupal_write_record($table), where this parameter has already been named $table.

The patch is straightforward and should not cause any side effects.

CommentFileSizeAuthor
#1 drupal_get_schema.patch1.11 KBPancho
drupal_get_schema.patch1.11 KBPancho
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pancho’s picture

Title: drupal_get_schema: confusing $name parameter » drupal_get_schema: unconsistent $name parameter
FileSize
1.11 KB

Rerolled patch against HEAD. Would be good to get this in.
While it is in some way an API change, it won't break anything, but make things more consistent and therefore easier for contrib developers.

TapocoL’s picture

Status: Active » Reviewed & tested by the community

Yes, pretty straight forward patch. I think the changing of the variable is a useful clarification. I ran quick tests on installing the poll module, creating a poll, viewing & voting on the poll, then uninstalling the poll. And, there were no problems. I think this is ready to be committed.

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.