Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In drupal_get_schema(), the parameter $name should IMHO be renamed to $table.
$name is confusing, as it could just as well represent the module name that is for example expected as parameter by drupal_install_schema($module).
But here it represents the table name, as in drupal_write_record($table), where this parameter has already been named $table.
The patch is straightforward and should not cause any side effects.
Comment | File | Size | Author |
---|---|---|---|
#1 | drupal_get_schema.patch | 1.11 KB | Pancho |
drupal_get_schema.patch | 1.11 KB | Pancho | |
Comments
Comment #1
PanchoRerolled patch against HEAD. Would be good to get this in.
While it is in some way an API change, it won't break anything, but make things more consistent and therefore easier for contrib developers.
Comment #2
TapocoL CreditAttribution: TapocoL commentedYes, pretty straight forward patch. I think the changing of the variable is a useful clarification. I ran quick tests on installing the poll module, creating a poll, viewing & voting on the poll, then uninstalling the poll. And, there were no problems. I think this is ready to be committed.
Comment #3
Gábor HojtsyThanks, committed.
Comment #4
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.