Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#22 | drupal-core_replace_theme_aggregator-2008970-22.patch | 1.37 KB | StephaneQ |
#22 | interdiff-20-22.txt | 680 bytes | StephaneQ |
#20 | drupal-core_replace_theme_aggregator-2008970-20.patch | 1.42 KB | StephaneQ |
#12 | twig-7563139-12.patch | 6.73 KB | adamcowboy |
#6 | drupal-core_replace_theme_aggregator-2008970-6.patch | 6.88 KB | markie |
Comments
Comment #1
thedavidmeister CreditAttribution: thedavidmeister commentedComment #2
markie CreditAttribution: markie commented3 files modified.
Comment #3
thedavidmeister CreditAttribution: thedavidmeister commentedThis looks good to me.
Comment #4
star-szrThanks for working on this @markie!
I'd like to see better or more descriptive variable names for the render arrays…
I'd rather see this var called $feed_icon or $source_icon instead of $themed.
Comment #5
thedavidmeister CreditAttribution: thedavidmeister commentedWe actually just updated the main issue summary:
Comment #6
markie CreditAttribution: markie commentedUpdated as requested.
Comment #7
eromero1 CreditAttribution: eromero1 commentedTested @markie's patch and everything worked properly. When the aggregator was fed, it responded as requested. There were no apparent issues.
Comment #8
sbudker1 CreditAttribution: sbudker1 commentedTested @markie's patch and was successful when using the feed aggregator! Everything seemed to work normally and there were no visible problems.
Comment #9
alexpottThis should just be on one line
Comment #10
thedavidmeister CreditAttribution: thedavidmeister commentedl() can take a renderable array for content now. no need to call drupal_render() on $image here.
Comment #11
adamcowboy CreditAttribution: adamcowboy commenteddibs!
Comment #12
adamcowboy CreditAttribution: adamcowboy commentedI fixed it (I think).
Comment #13
adamcowboy CreditAttribution: adamcowboy commentedComment #14
azinoman CreditAttribution: azinoman commenteddibs on review
Comment #15
azinoman CreditAttribution: azinoman commentedAggregator is working like we expect. I added a news feed and everything was working. Nice job Adam!
Comment #16
jenlamptonAnd nice job on the review azinoman!
Comment #17
alexpottCommitted 58c54c3 and pushed to 8.x. Thanks!
Comment #19
thedavidmeister CreditAttribution: thedavidmeister commentedtheme() still exists in aggregator. See RSS.php for example.
Comment #20
StephaneQI found 2 instances left in 2 files
Comment #21
pplantinga CreditAttribution: pplantinga commentedWhat if instead of #markup + drupal_render() we just use #theme?
$build['pager'] = array('#theme' => 'pager');
Comment #22
StephaneQComment #23
pplantinga CreditAttribution: pplantinga commentedLooks good to me!
I think it may be more appropriate to do this in #2046881: [meta] Avoid "early rendered" strings where beneficial to do so, build structured data to pass to drupal_render() once instead but at some point
return drupal_render($build)
will most likely need to become justreturn $build
Comment #24
webchickCommitted and pushed to 8.x. Thanks!