Replace theme() with drupal_render() in /core/lib [#2008954]

Comment	File	Size	Author
#9	drupal_remove_theme_core_lib-2008954-9.patch	4.29 KB	markie

#7	drupal_remove_theme_core_lib-2008954-7.patch	4.08 KB	markie

#4	drupal_remove_theme_core_lib-2008954-4.patch	4.08 KB	markie

#2	drupal_remove_theme_core_lib-2008954-2.patch	0 bytes	markie

Comment #1

thedavidmeister CreditAttribution: thedavidmeister commented 31 May 2013 at 13:12

Issue tags:

+Novice

Log in or register to post comments

Comment #2

markie CreditAttribution: markie commented 31 May 2013 at 23:48

Status:

Active

» Needs review

File	Size
drupal_remove_theme_core_lib-2008954-2.patch	0 bytes

4 files altered.

Log in or register to post comments

Comment #3

markie CreditAttribution: markie commented 31 May 2013 at 23:49

Assigned:

Unassigned

» markie

forgot to call dibs.

Log in or register to post comments

Comment #4

markie CreditAttribution: markie commented 31 May 2013 at 23:54

File	Size
drupal_remove_theme_core_lib-2008954-4.patch	4.08 KB

and.. it tends to help to save the files BEFORE doing your git diff.. Novice doesn't even scratch the surface.

Log in or register to post comments

Comment #5

1 June 2013 at 08:49

Status:

Needs review

» Needs work

The last submitted patch, drupal_remove_theme_core_lib-2008954-4.patch, failed testing.

Log in or register to post comments

Comment #6

thedavidmeister CreditAttribution: thedavidmeister commented 1 June 2013 at 09:00

-      $content = theme('maintenance_page', array('content' => filter_xss_admin(t(config('system.maintenance')->get('message'), array('@site' => config('system.site')->get('name'))))));
+      $build = array(
+        '#theme' => 'maintenance_page',
+        'content' => filter_xss_admin(
+          t(config('system.maintenance')->get('message'), array('@site' => config('system.site')->get('name')))
+        ),
+      );
+      $content = drupal_render($build);

You missed the # for #content.

Log in or register to post comments

Comment #7

markie CreditAttribution: markie commented 2 June 2013 at 04:02

Status:

Needs work

» Needs review

File	Size
drupal_remove_theme_core_lib-2008954-7.patch	4.08 KB

updated #content

Log in or register to post comments

Comment #8

thedavidmeister CreditAttribution: thedavidmeister commented 2 June 2013 at 23:57

Status:

Needs review

» Needs work

A minor styling thing, but we're only using $build when using #theme would conflict with another variable already in the local scope. Check the notes on the parent issue for more details :)