Looks like changes to the toolbar and this issue #1968430: Clean up css and markup for Tour module have caused the tour toggle to stop floating to the right.

CommentFileSizeAuthor
#3 2006598-3-tour-float-right.patch734 bytesnick_schuch
#1 2006598-1-tour-float-right.patch379 bytesnick_schuch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nick_schuch’s picture

nick_schuch CreditAttribution: nick_schuch commented
Status: Active » Needs review
FileSize
2006598-1-tour-float-right.patch379 bytes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue tags: +Quick fix 
+++ b/core/modules/tour/css/tour.cssundefined
@@ -4,7 +4,7 @@
+.js .toolbar .bar .tour-toolbar-tab.tab {
   float: right; /* LTR */
 }
 .js .toolbar .tour-toolbar-tab button {

this is an LTR definition, is there a .ltr file that needs updating too?

nick_schuch’s picture

nick_schuch CreditAttribution: nick_schuch commented
FileSize
2006598-3-tour-float-right.patch734 bytes

Correct! Cheers!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

assuming bot likes it

Status: Reviewed & tested by the community » Needs work
Issue tags: -Quick fix

The last submitted patch, 2006598-3-tour-float-right.patch, failed testing.

nick_schuch’s picture

nick_schuch CreditAttribution: nick_schuch commented
Status: Needs work » Needs review
Issue tags: +Quick fix

#3: 2006598-3-tour-float-right.patch queued for re-testing.

nick_schuch’s picture

nick_schuch CreditAttribution: nick_schuch commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC as per #4

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 8d79d9a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.