User picture messes up poll display [#20046]

Comment	File	Size	Author
#10	20046_user_picture_in_poll_1.patch	468 bytes	Sivaji_Ganesh_Jojodae

#10	localhost 2010-3-27 12:7.png	32.4 KB	Sivaji_Ganesh_Jojodae
#3	poll_picture_display_bluemarine.png	22.28 KB	baudolino
#1	poll_picture_display.png	29.09 KB	baudolino

Comment #1

baudolino CreditAttribution: baudolino commented 6 April 2005 at 03:54

File	Size
poll_picture_display.png	29.09 KB

Screenshot attached for clarification.

Log in or register to post comments

Comment #2

TDobes CreditAttribution: TDobes commented 6 April 2005 at 04:45

Assigned:

Unassigned

» TDobes

hrm... interesting. I wonder how many other themes have this problem. Does this sort of thing occur with bluemarine and pushbutton too? We might want to look at a more global solution than just changing goofy.

As an (untested) quick fix, open themes/goofy/goofy.theme in a text editor and change the following line:
if (theme_get_setting('toggle_node_user_picture') && $picture = theme('user_picture', $node)) {
to read:
if (theme_get_setting('toggle_node_user_picture') && ($node->type != 'poll') && $picture = theme('user_picture', $node)) {
in the goofy_node function.

This will omit user pictures for polls.

Log in or register to post comments

Comment #3

baudolino CreditAttribution: baudolino commented 6 April 2005 at 05:15

File	Size
poll_picture_display_bluemarine.png	22.28 KB

You ARE right, it's a general issue. I can confirm it with both bluemarine and pushbutton.

bluemarine screenshot attached for confirmation.

Log in or register to post comments

Comment #4

baudolino CreditAttribution: baudolino commented 7 May 2005 at 03:59

Your proposed quick patch solves indeed the problem (at least for Goofy).

On a global level, do you think the solution is patching theme.inc?

Log in or register to post comments

Comment #5

verber CreditAttribution: verber commented 21 August 2006 at 14:48

Another more global solution is to patch template engine (for example /themes/engines/xtemplate/xtemplate.engine)

On line 58 (function xtemplate_node) replace
if (theme_get_setting('toggle_node_user_picture') && $picture = theme('user_picture', $node)) {
by
if (theme_get_setting('toggle_node_user_picture') && theme_get_setting("toggle_node_info_{$node->type}",true) && $picture = theme('user_picture', $node)) {