drupal_container() is deprecated, and all calls in the entity_reference module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154)

CommentFileSizeAuthor
#4 replace-drupal_container-2003630-4.patch1.52 KBalexander.ilivanov
#1 2003630-1.patch1.52 KBebeyrent
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ebeyrent’s picture

ebeyrent CreditAttribution: ebeyrent commented
Status: Active » Needs review
FileSize
2003630-1.patch1.52 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Looks pretty good. I would assume that there is an issue to convert Drupal::service to Drupal::pluginManager

Status: Needs review » Needs work

The last submitted patch, 2003630-1.patch, failed testing.

alexander.ilivanov’s picture

alexander.ilivanov CreditAttribution: alexander.ilivanov commented
Assigned: ebeyrent » alexander.ilivanov
Status: Needs work » Needs review
Issue tags: +CodeSprintUA
FileSize
replace-drupal_container-2003630-4.patch1.52 KB

drupal_container() replaced
Patch attached.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Reviewed & tested by the community

if bot happy - rtbc
patch looks good for me

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 24f36dd and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.