Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#11 | views-rename_op_longer-2003566-11.patch | 1.03 KB | broeker |
#8 | views-rename_op_longer-2003566-8.patch | 1.02 KB | broeker |
#5 | views-rename_op_longer-2003566-5.patch | 1.02 KB | broeker |
#2 | rename_op_longer-2003566-2.patch | 1.02 KB | broeker |
Comments
Comment #1
broeker CreditAttribution: broeker commentedworking on it
Comment #2
broeker CreditAttribution: broeker commentedComment #4
zschmid CreditAttribution: zschmid commentedI believe the addLongerThan function should be public
Comment #5
broeker CreditAttribution: broeker commentedAdded public to addLongerThan function
Comment #6
heddnLooks good.
Comment #7
alexpottIn #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opLongerThan - i'm okay with adding the Than here as this is what it does.
Comment #8
broeker CreditAttribution: broeker commentedChanged op_longer to opLongerThan per comment in #7 . . .
Comment #9
heddnFixing title
Comment #10
dawehnerThanks for your work.
Method should be protected
Comment #11
broeker CreditAttribution: broeker commentedI was unclear whether this should be a public or protected function but per dawehner I've now changed it to a protected method:
Comment #12
dawehnerPerfect
Comment #13
webchickCommitted and pushed to 8.x. Thanks!
Moving to Views for the change notice.
Comment #14
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.