Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NonProfit’s picture

Assigned: Unassigned » NonProfit
NonProfit’s picture

Assigned: NonProfit » Unassigned
Status: Active » Needs review
FileSize
1.7 KB

Patch created.

Status: Needs review » Needs work

The last submitted patch, Rename_Views_method-2003554-2.patch, failed testing.

JeroenT’s picture

rename method op_contains to addContains.

JeroenT’s picture

Status: Needs work » Needs review

rename method op_contains to addContains.

Status: Needs review » Needs work

The last submitted patch, views-rename_op_contains_to_addContains-2003554-4.patch, failed testing.

JeroenT’s picture

Status: Needs work » Needs review
FileSize
1.71 KB

Rename op_contains() to opContains. This is the right one.

dawehner’s picture

Title: Rename Views method op_contains() to addContains() » Rename Views method op_contains() to opContains()
Status: Needs review » Needs work

Should be protected

JeroenT’s picture

Status: Needs work » Needs review
FileSize
1.95 KB

Rename op_contains to opContains. Added protected access modifier as mentioned by dawehner.

JeroenT’s picture

Wrong patch. Sorry!

dawehner’s picture

Nope #9 was the right patch ;)

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Combine.phpundefined
@@ -96,11 +96,11 @@ function opEqual($expression) {
+  ¶

Ups some whitespace appeared.

JeroenT’s picture

Ignore this patch. Sorry!

JeroenT’s picture

This is the right one! :)

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Looking good

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed ee9bb51 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.