In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opNotStartsWith - I'm okay with adding the with as this is what it does.
Comments
Comment #1
toddtomlinson CreditAttribution: toddtomlinson commentedComment #2
Elijah LynnI am going to give this a go right now at the DrupalCon Sprint!
Comment #3
Elijah LynnSorry Todd, we both did that at the same time coincidentally.
Comment #4
toddtomlinson CreditAttribution: toddtomlinson commentedHa! What are the odds?
Comment #5
toddtomlinson CreditAttribution: toddtomlinson commentedpatch attached that renames op_not_starts with addNotStartsWith
Comment #6
Elijah LynnYeah, small world!
Applies cleanly and no errors with mild testing.
Comment #8
alexweber CreditAttribution: alexweber commented#5: views.module-rename-op_not_starts-2003538-05.patch queued for re-testing.
Comment #10
JeroenTrename op_not_starts to addNotStartsWith.
Comment #11
JeroenTmarking as needs review.
Comment #12
heddnNo mentions of op_not_starts and applies cleanly. Passed testbot.
Comment #13
alexpottIn #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opNotStartsWith - I'm okay with adding the with as this is what it does.
Comment #14
nathangervais CreditAttribution: nathangervais commentedRerolled patch to rename op_not_starts() to opNotStartsWith
Comment #15
heddnFixing title.
Comment #16
aspilicious CreditAttribution: aspilicious commentedTalkes with dawehner about this, should be protected. Srry!
Comment #17
JeroenTChanged access modifier to protected as mentioned by aspilicious.
Comment #18
JeroenTMarking as needs review.
Comment #19
dawehnerPatch still applies and looks fine.
Comment #20
alexpottCommitted c5d336e and pushed to 8.x. Thanks!