Rename Views method get_total_items() to getTotalItems() [#2003494]

Comment	File	Size	Author
#6	views.core-2003494-rename-get_total_items-2003494-06.patch	2.05 KB	FredericoT

#2	views.core-2003494-rename-get_total_items-2003494-02.patch	2.05 KB	toddtomlinson

Comment #1

toddtomlinson CreditAttribution: toddtomlinson commented 24 May 2013 at 20:09

Assigned:

Unassigned

» toddtomlinson

Log in or register to post comments

Comment #2

toddtomlinson CreditAttribution: toddtomlinson commented 24 May 2013 at 20:42

Assigned:	toddtomlinson	» Unassigned
Status:	Active	» Needs review

File	Size
views.core-2003494-rename-get_total_items-2003494-02.patch	2.05 KB

Patch attached that renames get_total_items to getTotalItems

Log in or register to post comments

Comment #3

jameswoods CreditAttribution: jameswoods commented 24 May 2013 at 20:48

The method renaming code updates look good to me.

Log in or register to post comments

Comment #4

25 May 2013 at 01:04

Status:

Needs review

» Needs work

The last submitted patch, views.core-2003494-rename-get_total_items-2003494-02.patch, failed testing.

Log in or register to post comments

Comment #5

oenie CreditAttribution: oenie commented 25 May 2013 at 21:45

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -126,7 +126,7 @@ function set_current_page($number = NULL) {
+  function getTotalItems() {

Add public access modifier in front of the function to adhere to the new OOP standards.

Fix the above and the patch can be marked RTBC !