Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 drupal-views-rename-get-table-info-2003472-08.patch1.29 KBFredericoT
#3 drupal-views-rename-get-table-info-2003472.patch1.28 KBtrevorkjorlien
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented
Assigned: Unassigned » djdevin
trevorkjorlien’s picture

trevorkjorlien CreditAttribution: trevorkjorlien commented
Assigned: djdevin » trevorkjorlien

Working on this for DC Portland.

trevorkjorlien’s picture

trevorkjorlien CreditAttribution: trevorkjorlien commented
Assigned: trevorkjorlien » Unassigned
Status: Active » Needs review
FileSize
drupal-views-rename-get-table-info-2003472.patch1.28 KB

Renamed method "get_table_info()" to "getTableInfo()".

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-views-rename-get-table-info-2003472.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented
Status: Needs work » Needs review

#3: drupal-views-rename-get-table-info-2003472.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, drupal-views-rename-get-table-info-2003472.patch, failed testing.

oenie’s picture

oenie CreditAttribution: oenie commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -707,7 +707,7 @@ function get_join_data($table, $base_table) {
+  function getTableInfo($table) {

Add public access modifier in front of the function to adhere to the new OOP standards.

FredericoT’s picture

FredericoT CreditAttribution: FredericoT commented
Status: Needs work » Needs review
FileSize
drupal-views-rename-get-table-info-2003472-08.patch1.29 KB

Looks like this issues is inactive since DC Portland so I'm picking it up.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed df4aac2 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.