Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#13 | 2003470-rename-op_word-protected.patch | 1.13 KB | sillygwailo |
#12 | 2003470-rename-op_word.patch | 1.12 KB | sillygwailo |
#6 | 2003470-rename-op_word-protected.patch | 1.13 KB | sillygwailo |
#2 | 2003470-rename-op_word.patch | 1.12 KB | sillygwailo |
Comments
Comment #1
sillygwailoTaking this with baldwinlouie.
Comment #2
sillygwailoPatch attached, no manual testing (it appears only in one place).
Comment #4
sillygwailo#2: 2003470-rename-op_word.patch queued for re-testing.
Comment #5
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adhere to the new OOP standards.
Comment #6
sillygwailoRe-rolled with protected.
Comment #8
sillygwailo#6: 2003470-rename-op_word-protected.patch queued for re-testing.
Comment #10
sillygwailo#6: 2003470-rename-op_word-protected.patch queued for re-testing.
Comment #11
heddnIn #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_{foo} to add{foo}. So to be consistent this patch should just change the name to opContainsWord.
Comment #12
sillygwailoPatch attached.
Comment #13
sillygwailoWrong patch. Right one attached.
Comment #14
dawehnerComment #16
aspilicious CreditAttribution: aspilicious commentedComment #17
alexpottCommitted c6698cf and pushed to 8.x. Thanks!