Support from Acquia helps fund testing for Drupal Acquia logo

Comments

baldwinlouie’s picture

Assigned: Unassigned » baldwinlouie

taking with sillygwailo

baldwinlouie’s picture

attaching patch

baldwinlouie’s picture

Status: Active » Needs review

changing status

Status: Needs review » Needs work

The last submitted patch, drupal-camelcase-replace-2003460-7451340.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review
aspilicious’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -300,7 +300,7 @@ function operator_options() { return array(); }
+  function operatorValidate($form, &$form_state) { }

I think this should be "protected function operatorValidate()"

SpartyDan’s picture

Status: Needs work » Needs review
FileSize
1.11 KB

Added "protected"

Status: Needs review » Needs work

The last submitted patch, views-core-operator_validate-2003460-7.patch, failed testing.

SpartyDan’s picture

Status: Needs work » Needs review
FileSize
1.11 KB

re-roll

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 98c23ed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.