Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#9 renamed-is-exception-2002878-9.patch1.4 KBtheladebug
#7 renamed-is-exception-2002878-7.patch1.4 KBtheladebug
#5 views-rename_is_exception-2002878-.patch1.4 KBJeroenT
#2 drupal8-rename_is_execption_function-2002878-02.patch1.39 KBtoddtomlinson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

toddtomlinson’s picture

toddtomlinson CreditAttribution: toddtomlinson commented
Assigned: Unassigned » toddtomlinson

Creating patch.

toddtomlinson’s picture

toddtomlinson CreditAttribution: toddtomlinson commented
FileSize
drupal8-rename_is_execption_function-2002878-02.patch1.39 KB

Renamed is_exeception to isException in views. Patch attached.

BrockBoland’s picture

BrockBoland CreditAttribution: BrockBoland commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal8-rename_is_execption_function-2002878-02.patch, failed testing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs work » Needs review
FileSize
views-rename_is_exception-2002878-.patch1.4 KB

rename is_exception to isException().

Status: Needs review » Needs work

The last submitted patch, views-rename_is_exception-2002878-.patch, failed testing.

theladebug’s picture

theladebug CreditAttribution: theladebug commented
Assigned: toddtomlinson » Unassigned
Status: Needs work » Needs review
FileSize
renamed-is-exception-2002878-7.patch1.4 KB

Status: Needs review » Needs work

The last submitted patch, renamed-is-exception-2002878-7.patch, failed testing.

theladebug’s picture

theladebug CreditAttribution: theladebug commented
Status: Needs work » Needs review
FileSize
renamed-is-exception-2002878-9.patch1.4 KB

changed function visibility to public

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Thank you very much!

somepal’s picture

somepal CreditAttribution: somepal commented

reviewed.gtg with #9 renamed-is-exception-2002878-9.patch

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 8de2be7 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.