Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#8 | drupal-viewsRename-instantiate_view-2002872-7.patch | 1.64 KB | heddn |
#7 | drupal-viewsRename-page_display_options-2003436-14.patch | 4.56 KB | heddn |
#2 | views-rename-compile_fields-2002428-2.patch | 866 bytes | hansenm |
Comments
Comment #1
hansenm CreditAttribution: hansenm commentedI'm working on this at the DrupalCon Portland sprint.
Comment #2
hansenm CreditAttribution: hansenm commentedComment #4
heddnTests failing. Please investigate and re-roll a patch.
Comment #5
daven CreditAttribution: daven commented#2: views-rename-compile_fields-2002428-2.patch queued for re-testing.
Comment #6
daven CreditAttribution: daven commentedAccess modifier needs to be added to the function line as mentioned in the meta issue discussion:
http://drupal.org/node/1856630#comment-7451652
Should be "public function ..."
Comment #7
heddnActually, protected seems more appropriate ($this->instantiateView) is the only call. Let's see if it keeps the testbot happy.
Comment #8
heddnLet's try the right patch.
Comment #9
dcam CreditAttribution: dcam commented#8 looks good to me. All instances of the instantiate_view() method have been renamed. instantiateView() has been given protected visibility.
I think that #2 was mistakenly posted to the wrong issue. It should have gone into #2002428: Rename Views method compile_fields() to compileFields().
Comment #10
alexpottCommitted 7790f21 and pushed to 8.x. Thanks!