Remove unused local variables from core/includes/common.inc

Working on this.

@arknoll: You might want to use the "assigned" field to indicate this.

Removed variable.

Good to go

This looks like a bug to me rather than just an unused variable - isn't it trying to ensure that $options is an array in the return value?

 foreach ($module_libraries[$key]['js'] as $file => $options) {
          if (is_scalar($options)) {
            // The JavaScript or CSS file has been specified in shorthand
            // format, without an array of options. In this case $options is the
            // filename.
            $file = $options;
            $options = array();
          }

So it should write options back to the array (or act on a reference in the foreach()) rather than just discarding.

if (is_scalar($options))

checks if its scalar and intends to make $options available as array (for the next foreach pass maybe) if its the one. But initializing in this manner at the end of the foreach() pass, wouldn't serve that purpose. its not used further down the line as well. hence removed in the patch.

Instead of

$file = $options;
$options = array();

do we need

unset($module_libraries[$key]['js'][$file]);
$file = $options;

To ensure the original $file key is unset by the end of the foreach?

@longwave sorry could not agree that it was an unset attempt and I think we wouldn't need

unset($module_libraries[$key]['js'][$file]);

there, as

$module_libraries[$key]['js'][$file]['version']

is referred again as -

$module_libraries[$key]['js'][$file]['version'] = $module_libraries[$key]['version'];

At the same time, feels that it is not an attempt to initialize the variable to an array, as it wouldn't work that way, foreach() only works on the copy of the array unless passed as reference.

So the conclusion we should delete the line

$options = array();

safely and got ahead with patch #5 2002708-5-remove_unused_variables_common_inc.patch or #8 2002708_unused-local-var_8.patch

The comment above this block says "The JavaScript or CSS file has been specified in shorthand format, without an array of options. In this case $options is the filename". Firstly this is wrong because the loop explicitly looks at JavaScript only, not CSS, and secondly this "shorthand format" does not appear to be documented anywhere. The source of data for this loop is hook_library_info(), and the documentation there for the 'js' key says "An array of JavaScript elements; each element's key is used as $data argument, each element's value is used as $options array for drupal_add_js()". So, perhaps we should remove this check for the "shorthand format" entirely?

Updated issue summary.

8: 2002708_unused-local-var_8.patch queued for re-testing.

Tried re-rolling patch but failed. So created altogether new patch and submitting.

The performance impact of this is negligible, so retitling.

The $options variable may have been used previously in this scope, but appears to no longer be the case, so it is safe to remove.

Committed and pushed to 8.x. Thanks!