Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#3 renamed-exposed-filter-applied-200494-3.patch1.22 KBtvlooy
#1 renamed-exposed-filter-applied-200494.patch1.21 KBtheladebug
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

theladebug’s picture

theladebug CreditAttribution: theladebug commented
Status: Active » Needs review
FileSize
renamed-exposed-filter-applied-200494.patch1.21 KB
oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/InputRequired.phpundefined
@@ -50,7 +50,7 @@ public function submitOptionsForm(&$form, &$form_state) {
+  function exposedFilterApplied() {

Add protected access modifier in front of the function to adher to the new OOP standards.

tvlooy’s picture

tvlooy CreditAttribution: tvlooy commented
Status: Needs work » Needs review
FileSize
renamed-exposed-filter-applied-200494-3.patch1.22 KB

Added access modifier.

oenie’s picture

oenie CreditAttribution: oenie commented

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

theladebug’s picture

theladebug CreditAttribution: theladebug commented
Status: Needs review » Reviewed & tested by the community

passed testbot

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 9ca92e1 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.