Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#9 | 2002460-rename-default_not_found.patch | 1.06 KB | sillygwailo |
#4 | core-rename-default-not-found-2002460-5.patch | 1.05 KB | Anonymous (not verified) |
#2 | 2002460-rename-default_not_found.patch | 1.05 KB | sillygwailo |
Comments
Comment #1
sillygwailoTaking this with baldwinlouie.
Comment #2
sillygwailoPatch attached. Tested with a view that has a path, looks for a contextual filter, and has the contextual filter setting of "Page not found" when there's no argument. Test view is (correctly) page not found where there's no argument, tries to show a view if there is an argument.
Comment #3
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedRe-rolled and added public in front of function name.
Comment #5
dawehnerShouldn't that be better protected?
Comment #6
oenie CreditAttribution: oenie commented@dawehner: i wasn't sure in which context a method like that would be called, which is why i suggested public before.
Comment #7
dawehnerIt's called in ArgumentPluginBase::default_action()
Comment #8
heddnComment #9
sillygwailoRe-rolled with
protected
.Comment #11
sillygwailo#9: 2002460-rename-default_not_found.patch queued for re-testing.
Comment #12
aspilicious CreditAttribution: aspilicious commentedComment #13
alexpottCommitted e44d062 and pushed to 8.x. Thanks!