Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#5 drupal-camelcase-replace-2002458.5.patch1004 bytesbaldwinlouie
#2 drupal-camelcase-replace-2002458-7450896.patch997 bytesbaldwinlouie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Assigned: Unassigned » baldwinlouie

taking by baldwinlouie and sillygwailo

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
FileSize
drupal-camelcase-replace-2002458-7450896.patch997 bytes

attaching patch

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Active » Needs review

setting to needs review

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -681,7 +681,7 @@ public function validateFail() {
+  function defaultIgnore() {

Add public access modifier in front of the function to adher to the new OOP standards.

baldwinlouie’s picture

baldwinlouie CreditAttribution: baldwinlouie commented
Status: Needs work » Needs review
FileSize
drupal-camelcase-replace-2002458.5.patch1004 bytes

re-rolling with access modifier

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed f122f25 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.