Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 2002446-8.patch1.05 KBjibran
#8 interdiff.txt650 bytesjibran
#6 2002446-rename-default-default-6.patch1.04 KBfmizzell
#3 2002446-rename-default-default-3.patch1.03 KBfmizzell
#2 2002446-rename-default-default.patch1.02 KBfmizzell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Assigned: Unassigned » fmizzell
fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Status: Active » Needs review
FileSize
2002446-rename-default-default.patch1.02 KB
fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
FileSize
2002446-rename-default-default-3.patch1.03 KB

someone made me aware of the need for 'public' in front of the method as part of our coding standards.

Status: Needs review » Needs work

The last submitted patch, 2002446-rename-default-default-3.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented

Failing tests. Please test and re-roll.

fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Status: Needs work » Needs review
FileSize
2002446-rename-default-default-6.patch1.04 KB
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Needs work

Should be protected in stead of public

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review
FileSize
interdiff.txt650 bytes
2002446-8.patch1.05 KB

Converted to protected.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Nice!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed cad23a5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.