Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#18 | 2002434-rename-create_view.patch | 3.2 KB | sillygwailo |
#15 | 2002434-rename-create_view.patch | 3.51 KB | sillygwailo |
#13 | 2002434-rename-create_view.patch | 3.56 KB | sillygwailo |
#6 | 2002434-rename-create_view.patch | 3.57 KB | sillygwailo |
#2 | 2002434-rename-create_view.patch | 3.24 KB | sillygwailo |
Comments
Comment #1
sillygwailoTaking this with baldwinlouie.
Comment #2
sillygwailoHere's a patch.
Comment #3
sillygwailoComment #4
dawehnerThe standard is {@inheritdoc}, just have a look at [#1354]
I guess if we already change this exception message something like "Attempted to create a view with values that have not been validated."
This should be a public method
Comment #6
sillygwailoRe-rolled with the feedback.
Comment #8
dawehner#2: 2002434-rename-create_view.patch queued for re-testing.
Comment #10
dawehner#6: 2002434-rename-create_view.patch queued for re-testing.
Comment #11
oenie CreditAttribution: oenie commentedLooks good to me now.
Comment #12
alexpottNeeds a re-roll
Comment #13
sillygwailoRe-rolled against a recent pull of 8.x (retrieve_validated_view in the original patch changed in core to retrieveValidatedView so it should match in the 'unchanged' lines now).
Comment #14
dawehnerpublic and @inheritdoc
Comment #15
sillygwailoAdded, and re-rolled.
Comment #16
dawehnerEven I don't like this unrelated change ...
Comment #17
alexpottIf even @dawehner does not like the unrelated change displayed in #16... then lets not do it :)
Comment #18
sillygwailoRe-rolled with inheritDoc only for createView().
Comment #19
dawehnerThank you!
Comment #20
alexpottCommitted 577949f and pushed to 8.x. Thanks!