Rename Views method clear_fields() to clearFields() [#2002422]

Comment	File	Size	Author
#10	2002422-chng-clear_fields.patch	1.36 KB	aprice42

#8	2002950-chng-use_count_query-5.patch	1.38 KB	aprice42

#5	Rename_Views_method_clearFields-2002422-5.patch	1.64 KB	JeroenT

#2	Rename_Views_method-2002422-2.patch	1.36 KB	NonProfit

Comment #1

NonProfit CreditAttribution: NonProfit commented 24 May 2013 at 18:56

Assigned:

Unassigned

» NonProfit

Log in or register to post comments

Comment #2

NonProfit CreditAttribution: NonProfit commented 24 May 2013 at 19:12

Assigned:	NonProfit	» Unassigned
Status:	Active	» Needs review

File	Size
Rename_Views_method-2002422-2.patch	1.36 KB

Patch created.

Log in or register to post comments

Comment #3

dawehner

German

CreditAttribution: dawehner commented 24 May 2013 at 21:39

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -796,7 +796,7 @@ function add_field($table, $field, $alias = '', $params = array()) {
+  function clearFields() {

Should be marked as public

Log in or register to post comments

Comment #4

25 May 2013 at 01:01

Status:

Needs review

» Needs work

The last submitted patch, Rename_Views_method-2002422-2.patch, failed testing.

Log in or register to post comments

Comment #5

JeroenT

Dutch

🇧🇪

CreditAttribution: JeroenT commented 27 May 2013 at 10:41

File	Size
Rename_Views_method_clearFields-2002422-5.patch	1.64 KB

rename views method clear_fields to clearFields.

Log in or register to post comments

Comment #6

JeroenT

Dutch

🇧🇪

CreditAttribution: JeroenT commented 27 May 2013 at 11:34

Status:

Needs work

» Needs review

marking as needs review.

Log in or register to post comments

Comment #7

27 May 2013 at 16:12

Status:

Needs review

» Needs work

The last submitted patch, Rename_Views_method_clearFields-2002422-5.patch, failed testing.

Log in or register to post comments

Comment #8

aprice42 CreditAttribution: aprice42 commented 28 May 2013 at 17:07

Assigned:	Unassigned	» aprice42
Status:	Needs work	» Needs review

File	Size
2002950-chng-use_count_query-5.patch	1.38 KB

The submitted patch was wrapped in html. I removed the extra html and resubmitted.

Log in or register to post comments

Comment #9

29 May 2013 at 00:15

Status:

Needs review

» Needs work

The last submitted patch, 2002950-chng-use_count_query-5.patch, failed testing.

Log in or register to post comments

Comment #10

aprice42 CreditAttribution: aprice42 commented 29 May 2013 at 03:32

File	Size
2002422-chng-clear_fields.patch	1.36 KB

Looks like the original patch in comment 5 also had html replacement characters inside it and so really broke the code. recreated the changes locally and saved a new patch. I think this should do it.