Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#10 | rename_views_method-2002412-10.patch | 1.97 KB | marlatt |
#8 | 2002412-8.patch | 1.97 KB | marlatt |
#6 | 2002412-6.patch | 707 bytes | marlatt |
#2 | 2002412.patch | 700 bytes | davmorr |
Comments
Comment #1
davmorr CreditAttribution: davmorr commentedComment #2
davmorr CreditAttribution: davmorr commentedChanged cache_set_expire() to cacheSetExpire()
Comment #3
davmorr CreditAttribution: davmorr commentedComment #4
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #5
oenie CreditAttribution: oenie commenteddouble post - safely ignore
Comment #6
marlatt CreditAttribution: marlatt commentedAdded public to method. Patch looks good.
Comment #7
oenie CreditAttribution: oenie commentedI think you missed a few occurences of this method:
core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.php:128:
core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.php:133:
core/modules/views/lib/Drupal/views/Plugin/views/cache/Time.php:121:
In my previous comment i mentioned public as modifier, but since it seems to get invoked on $this, the access modifier can be protected instead of public.
Be sure to add it to the function declaration missed as well.
Comment #8
marlatt CreditAttribution: marlatt commentedRe-rolled patch with corrections from #7
Comment #10
marlatt CreditAttribution: marlatt commentedUnable to apply patch from #8 to create interdiff. Methods changed and method access set to protected.
Comment #12
aspilicious CreditAttribution: aspilicious commented#10: rename_views_method-2002412-10.patch queued for re-testing.
Comment #13
aspilicious CreditAttribution: aspilicious commentedComment #14
alexpottCommitted 8625dfc and pushed to 8.x. Thanks!