Support from Acquia helps fund testing for Drupal Acquia logo

Comments

brennanmh’s picture

Status: Active » Needs review
FileSize
2.84 KB

changed cache_expire to cacheExpire in CachePluginBase.php and Time.php

munizjor’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -142,11 +142,11 @@ function cache_set($type) {
-        return FALSE;

true and false have to be uppercase.

craychee’s picture

Assigned: Unassigned » craychee
oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -93,7 +93,7 @@ public function summaryTitle() {
+  function cacheExpire($type) { }

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/Time.phpundefined
@@ -107,7 +107,7 @@ function get_lifespan($type) {
+  function cacheExpire($type) {

Add protected access modifier in front of the functions to adher to the new OOP standards.

nathangervais’s picture

Assigned: craychee » nathangervais
Status: Needs work » Needs review
FileSize
1.58 KB

Rerolled patch using protectect access modifier and renaming the function to camelCase.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Looking good

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 486b8b8 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.