Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#9 views-rename_aggregation_method_simple-2002354-9.patch2.49 KBJeroenT
#6 views-aggregation-method-simple-2002354-6.patch572 bytesSpartyDan
#2 views-2002354-2-aggregation-method-simple.patch565 bytesIshaDakota
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

IshaDakota’s picture

IshaDakota CreditAttribution: IshaDakota commented
Assigned: Unassigned » IshaDakota
IshaDakota’s picture

IshaDakota CreditAttribution: IshaDakota commented
Assigned: IshaDakota » Unassigned
Status: Active » Needs review
FileSize
views-2002354-2-aggregation-method-simple.patch565 bytes

Status: Needs review » Needs work

The last submitted patch, views-2002354-2-aggregation-method-simple.patch, failed testing.

Gung Wang’s picture

Gung Wang CreditAttribution: Gung Wang commented
Assigned: Unassigned » Gung Wang

I take it.

oenie’s picture

oenie CreditAttribution: oenie commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1728,7 +1728,7 @@ function get_aggregation_info() {
+  function aggregationMethodSimple($group_type, $field) {

Add public access modifier in front of the function to adher to the new OOP standards.

SpartyDan’s picture

SpartyDan CreditAttribution: SpartyDan commented
FileSize
views-aggregation-method-simple-2002354-6.patch572 bytes

Added public access modifier in front of the function to adher to the new OOP standards.

SpartyDan’s picture

SpartyDan CreditAttribution: SpartyDan commented
Status: Needs work » Needs review

changed to needs review

Status: Needs review » Needs work

The last submitted patch, views-aggregation-method-simple-2002354-6.patch, failed testing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs work » Needs review
FileSize
views-rename_aggregation_method_simple-2002354-9.patch2.49 KB
oenie’s picture

oenie CreditAttribution: oenie commented

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 2cde13b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.