Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#9 | views-2002350-aggregation-method-distinct-9.diff | 1.04 KB | zschmid |
#7 | views-2002350-aggregation-method-distinct-6.patch | 1.11 KB | zschmid |
#2 | views-2002350-2-aggregation-method-distinct.patch | 712 bytes | IshaDakota |
Comments
Comment #1
IshaDakota CreditAttribution: IshaDakota commentedComment #2
IshaDakota CreditAttribution: IshaDakota commentedComment #3
Gung Wang CreditAttribution: Gung Wang commentedI take it.
Comment #4
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #5
oenie CreditAttribution: oenie commentedComment #6
zschmid CreditAttribution: zschmid commentedadding public access modifier
Comment #7
zschmid CreditAttribution: zschmid commentedComment #8
oenie CreditAttribution: oenie commentedSorry to throw this back again, but it seems we've missed a spot:
core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php, Line 1670:
'method' => 'aggregation_method_distinct'
Comment #9
zschmid CreditAttribution: zschmid commentedWoops - good catch. sorry about that. here's an updated patch.
Comment #10
zschmid CreditAttribution: zschmid commentedComment #11
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #12
alexpottCommitted e504933 and pushed to 8.x. Thanks!