Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#18 | drupal-viewsRename_adjust_join-2002346-18.patch | 3.97 KB | heddn |
#16 | 2002346-16.patch | 3.46 KB | jibran |
#11 | drupal-viewsRename_adjust_join-2002346-11.patch | 3.97 KB | heddn |
#6 | 2003242-6.patch | 17.45 KB | farfanfelipe |
#4 | VDC-Rename_adjust_join-2002346-4.patch | 3.46 KB | marlatt |
Comments
Comment #1
seantwalshWorking on this as part of the Portland2013 getting involved with core sprint.
Comment #2
seantwalshReplaced 7 instances of adjust_join with adjustJoin.
Comment #3
seantwalshOoooooooooooops!
Comment #4
marlatt CreditAttribution: marlatt commentedReviewed methods, added public to function.
Comment #5
farfanfelipe CreditAttribution: farfanfelipe commentedComment #6
farfanfelipe CreditAttribution: farfanfelipe commentedI added some more replacement that were not done in the complete views.module
Comment #7
marlatt CreditAttribution: marlatt commentedReviewed methods and functions.
Comment #8
attiks CreditAttribution: attiks commentedFYI: This patch contains a lot of other changes, not described in the issue summary, leaving at RTBC, but adding just so core committers see this.
Comment #9
farfanfelipe CreditAttribution: farfanfelipe commentedAdd Public to methods that have not visibility assigned is part of the new Drupal standards
Comment #10
alexpottThis patch should only touch the method adjust_join() and convert it to adjustJoin() - all other changes are out-of-scope and will conflict with related changes.
Comment #11
heddnRe-rolled. Marked method as protected rather than public since it only seems to be used internally.
Comment #13
nathangervais CreditAttribution: nathangervais commented#11: drupal-viewsRename_adjust_join-2002346-11.patch queued for re-testing.
Comment #14
aspilicious CreditAttribution: aspilicious commentedComment #15
alexpottNeeds a reroll
Comment #16
jibranreroll
Comment #18
heddnRerolled.
Comment #19
aspilicious CreditAttribution: aspilicious commentedComment #20
alexpottCommitted 863a9bd and pushed to 8.x. Thanks!