Support from Acquia helps fund testing for Drupal Acquia logo

Comments

seantwalsh’s picture

Assigned: Unassigned » seantwalsh
Issue tags: +portland2013

Working on this as part of the Portland2013 getting involved with core sprint.

seantwalsh’s picture

Replaced 7 instances of adjust_join with adjustJoin.

seantwalsh’s picture

Status: Active » Needs review

Ooooooooooooops!

marlatt’s picture

Reviewed methods, added public to function.

farfanfelipe’s picture

Status: Needs review » Reviewed & tested by the community
farfanfelipe’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
17.45 KB

I added some more replacement that were not done in the complete views.module

marlatt’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed methods and functions.

attiks’s picture

FYI: This patch contains a lot of other changes, not described in the issue summary, leaving at RTBC, but adding just so core committers see this.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1728,11 +1728,11 @@ function get_aggregation_info() {
-  function aggregation_method_simple($group_type, $field) {
+  public function aggregation_method_simple($group_type, $field) {
farfanfelipe’s picture

Add Public to methods that have not visibility assigned is part of the new Drupal standards

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

This patch should only touch the method adjust_join() and convert it to adjustJoin() - all other changes are out-of-scope and will conflict with related changes.

heddn’s picture

Status: Needs work » Needs review
FileSize
3.97 KB

Re-rolled. Marked method as protected rather than public since it only seems to be used internally.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC, -portland2013

The last submitted patch, drupal-viewsRename_adjust_join-2002346-11.patch, failed testing.

nathangervais’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC, +portland2013
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs a reroll

curl https://drupal.org/files/drupal-viewsRename_adjust_join-2002346-11.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4067  100  4067    0     0   1771      0  0:00:02  0:00:02 --:--:--  1914
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php:370
error: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php: patch does not apply
jibran’s picture

Status: Needs work » Needs review
FileSize
3.46 KB

reroll

Status: Needs review » Needs work

The last submitted patch, 2002346-16.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review
FileSize
3.97 KB

Rerolled.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 863a9bd and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.