Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#13 | views-2002270-remove-add_having-13.patch | 2.3 KB | vito_a |
#7 | views-2002270-addHaving-7.patch | 1.11 KB | zschmid |
#2 | views-2002270-addHaving.patch | 737 bytes | phenaproxima |
Comments
Comment #1
phenaproximaComment #2
phenaproximaComment #3
munizjor CreditAttribution: munizjor commentedRan successful test creating a new view.
Comment #5
chustedde CreditAttribution: chustedde commented#2: views-2002270-addHaving.patch queued for re-testing.
Comment #6
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #7
zschmid CreditAttribution: zschmid commentedadding public access modifier
Comment #8
oenie CreditAttribution: oenie commentedLooks fine to me now !
Comment #9
alexpottThis function does not seem to be called anywhere... is it needed?
Comment #10
dawehnerYes that's true there is no place currently in core which calls this function.
To be honest I can't think of a usecase of a having expression without using a snippet (like addHavingExpression() allows you)
as you always need an aggregation function. I would go with dropping support for it.
Comment #11
aspilicious CreditAttribution: aspilicious commented:)
Comment #12
vito_a CreditAttribution: vito_a commentedComment #13
vito_a CreditAttribution: vito_a commentedremoving it
Comment #14
dawehnerIf we really see that someone is using it we can readd it. This will not break any api in the future.
Comment #15
webchickCommitted and pushed to 8.x. Thanks!
Moving to Views for the change notice.
Comment #16
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.