Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Task to convert core/modules/views/lib/Drupal/views/Tests/PluginTypeListTest.php
to phpunit.
See #1938068: Convert UnitTestBase to PHPUnit.
Comment | File | Size | Author |
---|---|---|---|
#1 | views-plugintype-phpunit-2001218-01.patch | 854 bytes | jhedstrom |
Comments
Comment #1
jhedstromThis one is pretty simple.
Comment #2
ParisLiakos CreditAttribution: ParisLiakos commenteddead simple indeed:)
edit: that was completely misguided, so i deleted to avoid confusion
Comment #3
jhedstromThere seems to be a lot of different ways already where unit tests are placed. For instance, the breakpoint module (which I followed as an example)
core/modules/breakpoint/tests/Drupal/breakpoint/Tests/BreakpointMediaQueryTest.php
and an existing views test:
core/modules/views/tests/Drupal/Tests/views/UI/ViewsUITest.php
Don't we need
Tests
in the namespace, and if so, then don't we need that directory one way or another?Comment #4
ParisLiakos CreditAttribution: ParisLiakos commentedah, i am sorry you are right..thanks:)
Lets follow breakpoint example for now (although Core and Component does the reverse)
here is views ui test fixed:
#1998436: Wrong namespace for ViewsUITest
Comment #5
alexpottSweet!
Committed 3af1e98 and pushed to 8.x. Thanks!
Comment #7
jhedstrom