As part of #1238484: Ability to mark the form buttons to be of a specific type (so that they can be styled differently), the buttons.png file was removed, but .ui-slider .ui-slider-handle still references it in jquery.ui.theme.css

The effect is that when trying to place a jQuery UI slider in Seven:

  • a GET http://mysite/core/themes/seven/images/buttons.png 404 (Not Found) error message is thrown in the browser console, and the slider handle retains a transparent background.
  • a 'page not found' warning message is logged in the watchdog for core/themes/seven/images/buttons.png

Proposed resolution

Replace the reference to url(images/buttons.png) with a plain background color.

CommentFileSizeAuthor
#6 after-2.png1.31 KBmondrake
#6 after-1.png891 bytesmondrake
#6 before-2.png1.29 KBmondrake
#6 before-1.png763 bytesmondrake
#2 buttons-png_1999654_2.patch469 bytesmondrake
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Priority: Minor » Normal

Changing priority to normal.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Issue summary: View changes

more info

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Issue summary: View changes
Status: Active » Needs review
FileSize
buttons-png_1999654_2.patch469 bytes

This patch replaces the reference to url(images/buttons.png) with a plain background color.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Issue summary: View changes

Updated summary

zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie commented
Status: Needs review » Reviewed & tested by the community

Checked, I believe this patch is good enough.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs screenshots

Could we get a quick before/after screenshot on this? I can't tell exactly how to test this.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs screenshots
FileSize
before-1.png763 bytes
before-2.png1.29 KB
after-1.png891 bytes
after-2.png1.31 KB

Here we go.

Before:




After:


webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Gotcha. Well that seems fine, and much better than a 404. :) Thanks!

Committed and pushed to 8.x.

  • Commit 0cf0a52 on 8.x by webchick: 
    Issue #1999654 by mondrake: Missing buttons.png referenced in jquery.ui....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.