Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Files that need converting are:
- core/modules/system/lib/Drupal/system/Tests/Bootstrap/OverrideServerVariablesUnitTest.php
- core/modules/system/lib/Drupal/system/Tests/Common/RenderTest.php
- core/modules/system/lib/Drupal/system/Tests/Common/TableSortExtenderUnitTest.php
- core/modules/system/lib/Drupal/system/Tests/Database/SelectPagerDefaultTest.php
- core/modules/system/lib/Drupal/system/Tests/Entity/EntityQueryTest.php
- core/modules/system/lib/Drupal/system/Tests/Form/TriggeringElementTest.php
- core/modules/system/lib/Drupal/system/Tests/Theme/RegistryTest.php
- core/modules/system/system.admin.inc
- core/modules/system/system.api.php
- core/modules/system/system.install
- core/modules/system/system.module
- core/modules/system/tests/http.php
- core/modules/system/tests/https.php
- core/modules/system/tests/modules/ajax_test/ajax_test.module
- core/modules/system/tests/modules/form_test/form_test.module
- core/modules/system/tests/modules/menu_test/menu_test.module:
- core/modules/system/tests/modules/system_test/system_test.module
- core/modules/system/tests/modules/session_test/session_test.module
Comment | File | Size | Author |
---|---|---|---|
#14 | 1999434-system-request-14.patch | 1.32 KB | kim.pepper |
#14 | interdiff.txt | 1.15 KB | kim.pepper |
#12 | 1999434-system-request-12.patch | 1.34 KB | kim.pepper |
#3 | drupal-use_symfony_request_for_system_module-1999434-3.patch | 22.06 KB | atchijov |
Comments
Comment #1
atchijov CreditAttribution: atchijov commentedatchijov & johnbickar working on this.
Comment #2
John Bickar CreditAttribution: John Bickar commentedPer atchijov, unit tests for these changes will fail until https://drupal.org/node/1998696 is resolved.
Comment #3
atchijov CreditAttribution: atchijov commentedComment #4
John Bickar CreditAttribution: John Bickar commentedAlso per atchijov:
Comment #6
atchijov CreditAttribution: atchijov commented#3: drupal-use_symfony_request_for_system_module-1999434-3.patch queued for re-testing.
Comment #8
atchijov CreditAttribution: atchijov commentedComment #9
dawehner+++ b/core/modules/system/lib/Drupal/system/Tests/Bootstrap/OverrideServerVariablesUnitTest.phpundefined
@@ -25,10 +25,13 @@ public static function getInfo() {
+ $request = \Drupal::request();
+ $server = $request->server;
+ $script_name = $server->get('SCRIPT_NAME');
+++ b/core/modules/system/lib/Drupal/system/Tests/Common/RenderTest.phpundefined
@@ -139,8 +139,9 @@ function testDrupalRenderSorting() {
+ $server = \Drupal::request()->server;
+ $request_method = $server->get('REQUEST_METHOD');
On a pure unit test the Drupal request will not be available here. We should use Request::createFormGlobals(); instead
Comment #10
atchijov CreditAttribution: atchijov commented#3: drupal-use_symfony_request_for_system_module-1999434-3.patch queued for re-testing.
Comment #12
kim.pepperOnly converting the system.php and system.api.php as the tests can be converted post api freeze.
Comment #13
larowlanThese will always be set. I think you need !empty() now.
Can this be combined into one line?
Comment #14
kim.pepperFixes for #13.
Comment #15
larowlanComment #16
YesCT CreditAttribution: YesCT commentedThis issue was RTBC and passing tests on July 1, the beginning of API freeze.
Comment #17
alexpottCommitted 09d7b81 and pushed to 8.x. Thanks!