Part of #1998638: Replace almost all remaining superglobals ($_GET, $_POST, etc.) with Symfony Request object

Files that need converting are:

  • core/modules/simpletest/lib/Drupal/simpletest/UnitTestBase.php
CommentFileSizeAuthor
#13 1999430-use-symfony-request-for-simpletest-module.patch538 bytesslv_
#9 drupal8.base-system.1999430-9.patch574 bytesandypost
#2 1999430_2-replace-server-simpletest.patch594 byteschertzog
#1 1999430_1-replace-server-simpletest.patch593 byteschertzog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
Assigned: Unassigned » chertzog
Status: Active » Needs review
FileSize
1999430_1-replace-server-simpletest.patch593 bytes
chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
FileSize
1999430_2-replace-server-simpletest.patch594 bytes

Fix the namespaced version.

Status: Needs review » Needs work

The last submitted patch, 1999430_2-replace-server-simpletest.patch, failed testing.

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
Status: Needs work » Needs review

#2: 1999430_2-replace-server-simpletest.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1999430_2-replace-server-simpletest.patch, failed testing.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented
Status: Needs work » Needs review

#2: 1999430_2-replace-server-simpletest.patch queued for re-testing.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented

This looks ok. Might be called too early when the container isn't initialised.

Status: Needs review » Needs work

The last submitted patch, 1999430_2-replace-server-simpletest.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs work » Needs review
FileSize
drupal8.base-system.1999430-9.patch574 bytes

Suppose this only needed for drupal_valid_test_ua() but not sure it's needed at all.

Crell’s picture

Crell CreditAttribution: Crell commented

I guess that line isn't needed and we can just remove it. :-)

Crell’s picture

Crell CreditAttribution: Crell commented
Issue tags: +Novice, +WSCCI

Tagging.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

This needs a reroll for an actual remove of the line.

slv_’s picture

slv_ CreditAttribution: slv_ commented
Status: Needs work » Needs review
FileSize
1999430-use-symfony-request-for-simpletest-module.patch538 bytes

Re-rolled. Removed line.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Thank you

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Yay. :)

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.