Part of #1998638: Replace almost all remaining superglobals ($_GET, $_POST, etc.) with Symfony Request object

Files that need converting are:

  • core/modules/filter/filter.module
CommentFileSizeAuthor
#5 1999376-use-symfony-request-filter-module-5.patch766 byteschrisjlee
#5 interdiff.txt808 byteschrisjlee
#1 1999376_1-remove-SERVER-filter.patch775 byteschertzog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
Status: Active » Needs review
FileSize
1999376_1-remove-SERVER-filter.patch775 bytes
chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
Assigned: Unassigned » chertzog
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented
Status: Needs review » Needs work

Looking good.

+++ b/core/modules/filter/filter.moduleundefined
@@ -1741,7 +1741,8 @@ function _filter_html_image_secure_process($text) {
+    $host = Drupal::request()->server->get('HTTP_HOST');

Can just be $request->getHost()

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented

Are you still working on this chertzog?

chrisjlee’s picture

chrisjlee CreditAttribution: chrisjlee commented
FileSize
interdiff.txt808 bytes
1999376-use-symfony-request-filter-module-5.patch766 bytes

I'll give this a shot.

chrisjlee’s picture

chrisjlee CreditAttribution: chrisjlee commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1999376-use-symfony-request-filter-module-5.patch, failed testing.

aaronott’s picture

aaronott CreditAttribution: aaronott commented
Status: Needs work » Needs review

#5: 1999376-use-symfony-request-filter-module-5.patch queued for re-testing.

Looking through the error logs, it seemed that there was a hiccup on the testing server rather than an error in the code.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +quickfix

Looks good.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.