Use Symfony Request for block module [#1998708]

Comment	File	Size	Author
#8	1998708-block-request-8.patch	2.42 KB	kim.pepper

#4	1998708-block-request-4.patch	19.25 KB	kim.pepper

#1	1998708_1.patch	2.46 KB	kmcculloch

Comment #1

kmcculloch CreditAttribution: kmcculloch commented 20 May 2013 at 18:18

Status:

Active

» Needs review

File	Size
1998708_1.patch	2.46 KB

Initial attempt to convert, using (what I believe are) proper Symfony methods

Log in or register to post comments

Comment #2

kim.pepper

English

🏄‍♂️🇦🇺Sydney, Australia

CreditAttribution: kim.pepper commented 30 May 2013 at 10:58

+++ b/core/modules/block/block.moduleundefined
@@ -315,7 +315,7 @@ function _block_get_renderable_region($list = array()) {
+    !in_array(\Drupal::request()->server->get('REQUEST_METHOD'), array('GET', 'HEAD'));

This could just be $request->isMethod('GET') || $request->isMethod('HEAD')

Log in or register to post comments

Comment #3

kim.pepper

English

🏄‍♂️🇦🇺Sydney, Australia

CreditAttribution: kim.pepper commented 30 May 2013 at 10:58

Status:

Needs review

» Needs work

Log in or register to post comments

Comment #4

kim.pepper

English

🏄‍♂️🇦🇺Sydney, Australia

CreditAttribution: kim.pepper commented 1 June 2013 at 20:54

Status:

Needs work

» Needs review

File	Size
1998708-block-request-4.patch	19.25 KB

There is now only one occurrence of PHP superglobals, so I started this again from scratch. I've used a $request-isMethodSafe() to encapsulate the same check.

Log in or register to post comments

Comment #5

2 June 2013 at 06:20

Status:

Needs review

» Needs work

The last submitted patch, 1998708-block-request-4.patch, failed testing.

Log in or register to post comments

Comment #6

Steven Merrill CreditAttribution: Steven Merrill commented 6 June 2013 at 15:11

Status:

Needs work

» Needs review

#4: 1998708-block-request-4.patch queued for re-testing.

Log in or register to post comments

Comment #7

Crell CreditAttribution: Crell commented 13 June 2013 at 02:00

Status:

Needs review

» Needs work

+++ b/core/includes/menu.inc
@@ -917,7 +926,8 @@ function _menu_link_translate(&$item, $translate = FALSE) {
+        $item['access'] = drupal_container()->get('access_manager')->check($route, $request);

This should be Drupal::service('access_manager')

There's also a ton of unrelated config system stuff going on in there. Looks like a patch got mixed up by accident.