Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Boolean views fields can be given specialized true/false values:
Here is the same field, but as an exposed filter:
Related issues:
Comment | File | Size | Author |
---|---|---|---|
#28 | 1998192-28.patch | 12.45 KB | damiankloip |
#25 | 1998192-25.patch | 12.44 KB | damiankloip |
#25 | interdiff-1998192-25.txt | 1.91 KB | damiankloip |
#22 | 1998192-23.patch | 12.82 KB | damiankloip |
#21 | 1998192-22.patch | 534 bytes | damiankloip |
Comments
Comment #1
dawehnerThis is a start to allow to configure any kind of label using the grouped filter functionality.
Comment #2
dawehnerLet's add proper test + fix some notices.
Comment #3
jibranI think this is by mistake or missing assertion.
Comment #4
dawehnerFixed that.
Comment #5
dawehnerFixed that.
Comment #6
damiankloip CreditAttribution: damiankloip commentedHere is a test for the actual logic of the filter value. Things are slightly broken atm.
Comment #7
damiankloip CreditAttribution: damiankloip commentedComment #8
damiankloip CreditAttribution: damiankloip commentedFixed up based on your feedback, thanks Daniel.
Sorry, missed the interdiff.
EDIT: This is the wrong patch. #7 is good. posted on the wrong issue.
Comment #10
ParisLiakos CreditAttribution: ParisLiakos commented#7: 1998192-7.patch queued for re-testing.
Comment #11
damiankloip CreditAttribution: damiankloip commented#8: 1998192-8.patch queued for re-testing.
Comment #13
damiankloip CreditAttribution: damiankloip commentedWe just need to retest #7.
Comment #15
xjm#13: 1998192-7.patch queued for re-testing.
Comment #17
damiankloip CreditAttribution: damiankloip commentedI *think* this should fix the tests now. Let's see..
Comment #18
dawehnerSorry .. needs docs.
Could get one @see as well.
So for the UI test we alter and for the unit test we add this feel all the time? This seems unconsistent. I would personally vote to alter both times.
yeah!!
Comment #19
damiankloip CreditAttribution: damiankloip commentedI'm not sure about altering the views test data to add this handler, as for things like ID we always have that field around, status we don't so altering wouldn't help? not unless we already had a handler on the view, but it would use Boolean anyways.
Comment #21
damiankloip CreditAttribution: damiankloip commentedComment #22
damiankloip CreditAttribution: damiankloip commentedSorry, with the right patch and not two interdiffs.
Comment #23
dawehnerI still think that if we add boolean fields to all beatles we should leverage it in both tests.
Comment #24
dawehner:(
Comment #25
damiankloip CreditAttribution: damiankloip commentedSorry, I see exactly what you mean now. We should use the status handler in the UI test instead of altering the data on the age field :)
Comment #26
dawehnerI'm glad you understood me. Perfect! (Once the testbot liked us).
Comment #27
alexpottNeeds a reroll...
Comment #28
damiankloip CreditAttribution: damiankloip commentedrerolled
Comment #29
dawehnerBack to RTBC, yeah!
Comment #30
alexpottCommitted 0e8571d and pushed to 8.x. Thanks!
Comment #31
dawehnerThis wasn't perfect yet :( #2024893-4: Change status filter on admin/people to 'active'/'blocked'