Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
From #1927608-197: Remove the tight coupling between Block Plugins and Block Entities by @catch:
It's also weird that we specify both the plugin and the module in block config but that predates the patch so meh.
I agree with catch. It seems weird that block plugins require 'module' to be passed as configuration rather than figuring it out some other way.
Comment | File | Size | Author |
---|---|---|---|
#15 | 1991442_15.patch | 24.64 KB | benjy |
#11 | block-provider-1991442-11.patch | 24.37 KB | tim.plunkett |
Comments
Comment #1
benjy CreditAttribution: benjy commented$plugin_definition contains a "provider" key and a "module" key. Are they ever different? Maybe we could just use the provider key instead?
Comment #2
jibran@tim.plunkett++ It is fixed in #2065721: Add a dedicated @Block plugin annotation
Comment #3
tim.plunkettI don't thinking actually fixed it, I'll post a patch showing what I mean.
Comment #4
jibranIn all fairness the title of the issue is confusing. I realized that after reading the original comment by @catch.
Comment #5
tim.plunkettThe 'module' needs to be stored due to how BlockPluginBag handles exceptions for disabled modules.
Postponing on #1199946: Disabled modules are broken beyond repair so the "disable" functionality needs to be removed
Comment #6
tim.plunkettThis is what I meant.
Comment #8
tim.plunkettWell yeah, I guess that would be a problem :)
Comment #9
dawehnerPerfect!
Comment #11
tim.plunkett#2158003: Remove Block Cache API in favor of blocks returning #cache with cache tags moved some code around, but nothing changed here.
Comment #13
tim.plunkettCan we turn off the auto retest until the known bot issues are resolved?
Comment #14
alexpottblock-provider-1991442-11.patch no longer applies.
Comment #15
benjy CreditAttribution: benjy commentedRe-roll.
Comment #16
tim.plunkettComment #18
alexpottCommitted 41b6df5 and pushed to 8.x. Thanks!
Fixed whitespace errors on commit
Comment #19
tim.plunkettNo idea how that got in there, thanks.