"Edit shortcuts" link in the toolbar points to a nonexistent page (as does the "add shortcuts" link on an empty shortcut set) [#1991092]

Comment	File	Size	Author
#5	1993992-shortcut-tests.patch	825 bytes	andypost

#1	shortcut-urls-1991092-1.patch	1.68 KB	David_Rothstein

Comment #1

David_Rothstein CreditAttribution: David_Rothstein commented 9 May 2013 at 15:45

Title:	"Edit shortcuts" link in the toolbar points to a nonexistent page	» "Edit shortcuts" link in the toolbar points to a nonexistent page (as does the "add shortcuts" link on an empty shortcut set)
Status:	Active	» Needs review
Issue tags:		+Needs tests

File	Size
shortcut-urls-1991092-1.patch	1.68 KB

Found another while looking through the module. Both are fixed in the attached.

I guess in theory this indicates some missing test coverage.

Log in or register to post comments

Comment #2

David_Rothstein CreditAttribution: David_Rothstein commented 9 May 2013 at 15:47

Though I don't know; a test would only catch this if it used clickLink() and specifically simulated clicking thorough the user interface rather than navigating by URL.

We don't tend to write tests that way too often.

Log in or register to post comments

Comment #3

aspilicious CreditAttribution: aspilicious commented 11 May 2013 at 14:07

Status:

Needs review

» Reviewed & tested by the community

Not sure why this is critical but lets close this one...

Log in or register to post comments

Comment #4

catch

he/him

English

CreditAttribution: catch commented 13 May 2013 at 21:11

Status:

Reviewed & tested by the community

» Fixed

Don't think this is worth a test. Committed/pushed to 8.x, thanks!

Log in or register to post comments

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost commented 13 May 2013 at 21:59

Priority:	Critical	» Normal
Status:	Fixed	» Needs review
Issue tags:	-Needs tests

File	Size
1993992-shortcut-tests.patch	825 bytes

Closed as duplicate #1993992: Edit shortcuts toolbar link broken

Here's a tests

Log in or register to post comments

Comment #6

13 May 2013 at 22:56

Status:

Needs review

» Needs work

The last submitted patch, 1993992-shortcut-tests.patch, failed testing.

Log in or register to post comments

Comment #7

rszrama CreditAttribution: rszrama commented 24 June 2013 at 19:30

Status:

Needs work

» Fixed

I don't see what that test gains us, as it simply ensures the shortcut URL hasn't changed since installation. This test wouldn't even start failing if the actual shortcuts path were to be changed again in the future. I agree with the previous comments that this doesn't need a test, as I couldn't find any comparable tests in the codebase.