Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#18 | 1990156-18.patch | 4.38 KB | damiankloip |
#18 | interdiff-1990156-18.txt | 502 bytes | damiankloip |
#16 | 1990156-16.patch | 4.54 KB | damiankloip |
#16 | interdiff-1990156-16.txt | 964 bytes | damiankloip |
#14 | 1990156-14.patch | 4.35 KB | damiankloip |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedComment #2
dawehnerdb.condition-annotation.patch queued for re-testing.
Comment #4
dawehnerdb.condition-annotation.patch queued for re-testing.
Comment #5
dawehnerdb.condition-annotation.patch queued for re-testing.
Comment #7
damiankloip CreditAttribution: damiankloip commentedRerolled. If we want to do this, we can't really call the PluginManagerBase constructor like we currently are. So I think we really need to just override the whole thing:
Comment #8
damiankloip CreditAttribution: damiankloip commentedMeh, sorry. We need to also use ContainerFactory and NOT DefaultFactory.
Comment #9
dawehnerAll these parameters could be solved by calling parent::__construct with these parameters, so just the alterdecorator is needed. The containerfactory also exists on the parent.
The defaultPluginManager already cares about caching, so this should not be added here.
Comment #10
damiankloip CreditAttribution: damiankloip commentedthank you, so we can just do this...
We don't need to implement an alter decorator either, as this is also taken care of on the parent.
Comment #11
dawehnerPerfect!
Comment #12
alexpottHow come all the new use statements? They don't appear to be... used :)
Missing a space...
$annotation_namespaces,'Drupal\Core\Condition\Annotation\Condition'
Given #2022087: Add module owner to plugin definition in AnnotatedClassDiscovery should we clean up the module key here too or is that out-of-scope... actually I guess it is.
Comment #13
damiankloip CreditAttribution: damiankloip commentedYou're totally right.
Comment #14
damiankloip CreditAttribution: damiankloip commentedSpoke to alexpott on IRC, Let's also take care of the module key in the annotations too.
Comment #16
damiankloip CreditAttribution: damiankloip commentedThat classic comma in an annotation again :)
Comment #17
dawehnerLet me think for second .. . this can't work, even in PHP.
Comment #18
damiankloip CreditAttribution: damiankloip commentedHaha, no, certainly not!
Comment #19
dawehnerPerfect, wow this needed quite a big amount of comments.
Comment #20
alexpottCommitted 377521e and pushed to 8.x. Thanks!