Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#28 | 1987660-config-sync-28.patch | 15.54 KB | ygerasimov |
#28 | 1987660-config-sync-28-interdiff.txt | 4.02 KB | ygerasimov |
#26 | 1987660-config-sync-26.patch | 15.02 KB | ygerasimov |
#26 | 1987660-config-sync-26-interdiff.txt | 6.36 KB | ygerasimov |
#23 | 1987660-config-sync-23.patch | 14.8 KB | ygerasimov |
Comments
Comment #1
marcingy CreditAttribution: marcingy commentedFirst pass
Comment #2
marcingy CreditAttribution: marcingy commentedComment #4
marcingy CreditAttribution: marcingy commented#1: config-sync.patch queued for re-testing.
Comment #5
aspilicious CreditAttribution: aspilicious commentedTrailing whitespace
Comment #6
alexpottPostponing this on #1890784: Refactor configuration import and sync functions as that issue will result in significant changes to this patch
Comment #7
vijaycs85#1890784: Refactor configuration import and sync functions is in...
Comment #8
vijaycs85#1: config-sync.patch queued for re-testing.
Comment #10
swiftsure CreditAttribution: swiftsure commentedCode sprint note.
I am working on this issue.
Comment #11
dougvann CreditAttribution: dougvann commentedRerolled patch
corrected white space in lib/Drupal/config/Form/ConfigSync.php
corrected file removal of config.admin.inc
BIG THNX to Benjifisher http://drupal.org/user/683300 for lots of help and my team mate swiftsure for our 1st major contribution.. ;-)
Comment #12
aspilicious CreditAttribution: aspilicious commentedThe new file is missing :)
Ask for help on creating patches with new files!
Go for it!
Comment #13
dougvann CreditAttribution: dougvann commentedThnx aspilicious !
Here it is.
Comment #15
dougvann CreditAttribution: dougvann commentedMy n00b mistake has been corrected. Addition of whitespace in hunk has been removed.
Comment #17
vijaycs85Re-rolling...
Comment #19
vijaycs85Missed routing file change...
Comment #21
vijaycs85#19: 1987660-config-sync-19.patch queued for re-testing.
Comment #23
ygerasimov CreditAttribution: ygerasimov commentedRebuilt the patch (nearly from scratch). Lets see how tests will pass.
Comment #24
dawehnerLet's camelCase the method.
I don't see why we need a helper function here ...
t could be replaced by the translation manager.
Comment #25
star-szrBased on the above this needs work.
Comment #26
ygerasimov CreditAttribution: ygerasimov commentedPatch changed according to #24. Thank you for the review.
Comment #27
dawehnerPattern should start with a slash.
I would vote to go with the TranslatorInterface
For now we could use getPathFromRoute on the url generator.
Let's keep the usual order and move validateForm before submitForm
Comment #28
ygerasimov CreditAttribution: ygerasimov commentedRerolled patch.
Comment #29
dawehnerJust in general this page is really nice with its diff functionality.
Comment #30
alexpottCommitted 0adc91a and pushed to 8.x. Thanks!
Comment needed to be reformatted so that lines where less than 80 characters long.