Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Beta phase evaluation
Issue category | Task because it's updating code to the new API |
---|---|
Unfrozen changes | Unfrozen because it's a change in automated tests |
Comment | File | Size | Author |
---|---|---|---|
#27 | 1987612-26.patch | 4.18 KB | aspilicious |
#21 | 1987612-21.patch | 3.92 KB | valthebald |
#20 | 1987612-20.patch | 3.92 KB | valthebald |
#18 | 1987612-18.patch | 3.91 KB | valthebald |
#15 | 1987612_interdiff_11_44.txt | 1.51 KB | valthebald |
Comments
Comment #1
vijaycs85Need to rewrite the whole module to make test sync with current test implementation. For more details, please refer: #1988802: [META] Rewrite test modules in system to provide better unit testing.
Comment #2
ayelet_Cr CreditAttribution: ayelet_Cr commentedComment #3
mparker17I'll help!
Comment #4
mparker17This appears to be already done in commit
22df596
! :DComment #5
vijaycs85The commit mentioned in #4 isolated ajax_test_dialog_contents(), but it is not removing it. Still we have a controller method that calls ajax_test_dialog_contents().
Comment #6
InternetDevels CreditAttribution: InternetDevels commentedLet's see...
Comment #7
PinoloComment #8
PinoloPatch #6 doesn't apply any more. Attaching an equivalent patch that applies to latest HEAD.
Comment #10
Mile23Comment #11
Mile23Reroll.
Comment #13
PinoloComment #14
valthebaldComment #15
valthebaldThere were 2 reasons for failing tests:
Both fixed, see attached patch
Comment #16
David Hernández CreditAttribution: David Hernández commentedHello!
Thank you for working on this issue!
We should all try and use the same sprint tag. According to https://groups.drupal.org/node/447258 it should be SprintWeekend2015 with no #.
Comment #17
Mile23Add @return to the docblock, please. https://www.drupal.org/coding-standards/docs#return
Comment #18
valthebaldAdded @return to docblock per #17
Comment #19
Mile23Thanks... But now there has to be an empty line before the @return annotation. :-)
So like this:
Comment #20
valthebaldHere we go!
Comment #21
valthebaldRemoved extra space in separator comment line
Comment #23
Mile23Diggit. :-)
Refactors
ajax_test_dialog_contents()
intoAjaxTestController::dialogContents()
.Comment #25
alexpottComment #26
aspilicious CreditAttribution: aspilicious commentedComment #27
aspilicious CreditAttribution: aspilicious commentedComment #28
aspilicious CreditAttribution: aspilicious commentedI just rerolled this one. ANd triple checked my reroll was complete.
Comment #29
Wim LeersLooks good!
RTBC++
Comment #30
alexpottCommitted fa9e185 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.