Convert layout_test_page() to a Controller [#1985570]

Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Comment	File	Size	Author
#6	layout_test_controller-1985570-6.patch	4.28 KB	plopesc
#6
#6	interdiff.txt	684 bytes	plopesc
#3	layout_test_controller-1985570-3.patch	4.27 KB	plopesc
#3
#3	interdiff.txt	844 bytes	plopesc
#1	layout_test_controller-1985570-1.patch	3.28 KB	plopesc
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

plopesc

he/him

Spanish

CreditAttribution: plopesc commented 2 May 2013 at 21:11

Assigned:	Unassigned	» plopesc
Status:	Active	» Needs review

File	Size
layout_test_controller-1985570-1.patch	3.28 KB

Hello.

Attaching patch that converts layout_test_page() to a Controller.

Regards

Comment #2

dawehner

German

CreditAttribution: dawehner commented 2 May 2013 at 23:04

+++ b/core/modules/layout/tests/lib/Drupal/layout_test/Controller/LayoutTestController.phpundefined
@@ -0,0 +1,42 @@
+    $display = entity_load('display', 'test_twocol');

entityLoad could be replayed by an injected entity storage controller.

Comment #3

plopesc

he/him

Spanish

CreditAttribution: plopesc commented 3 May 2013 at 12:58

File	Size
interdiff.txt	844 bytes
layout_test_controller-1985570-3.patch	4.27 KB

Re-rolled patch injecting entity storage controller.

Maybe theme_enable hack could be replaced because uses internally some configuration system dependencies.

What do you think?

Regards.

Comment #4

dawehner

German

CreditAttribution: dawehner commented 4 May 2013 at 00:52

He, you interdiffs seems to be out of scope somehow.

+++ b/core/modules/layout/tests/lib/Drupal/layout_test/Controller/LayoutTestController.phpundefined
@@ -0,0 +1,70 @@
+   * Page callback for layout testing.

Do we have a better description then "page callback"? This seems very D7-ish.