For contrib's sake, every core manager should have an AlterDecorator. Here's one for tip.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

Issue tags: +Needs tests

We need some new tests here
Other than that, good to go

tim.plunkett’s picture

I disagree, we don't need to have a test for every plugin manager that uses AlterDecorator.
AlterDecorator has its own tests.

larowlan’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Fair nuff

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs a reroll...

$ curl https://drupal.org/files/tip-alterdecorator.patch | git a
error: patch failed: core/modules/tour/lib/Drupal/tour/TipPluginManager.php:28
error: core/modules/tour/lib/Drupal/tour/TipPluginManager.php: patch does not apply
tim.plunkett’s picture

Status: Needs work » Reviewed & tested by the community
FileSize
1.9 KB

'tour', 'tip' to 'tour/tip' was in the patch context. No change. Back to RTBC.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Plugin system

The last submitted patch, tour-1984648-5.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
Issue tags: +Plugin system

#5: tour-1984648-5.patch queued for re-testing.

alexpott’s picture

Status: Needs review » Fixed

Committed 0cf4cd3 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.