Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Select a caching mode and click "Save configuration". The next page will say "configuration saved" but none of the caching mode bullets will be selected. Expected result: Current caching mode will be selected to inform the user which mode is in use.
OS: Linux
WS: Apache 1.3
PHP: 4.3
Drupal: 6.0B4
Path: /
Comment | File | Size | Author |
---|---|---|---|
#10 | clear.patch | 949 bytes | catch |
Comments
Comment #1
treksler CreditAttribution: treksler commentedIt may be worse than that
it looks like it could be that the bullet doesn't show because cache doesn't get enabled AT ALL
I ran apache bench and results are same no matter what you choose
i get 13-15 requests per second (no matter which option i click)
Drupal 6.0B4
Path:/admin/settings/performance
OS: Red Hat Enterprise Linux AS release 4 (Nahant Update 4)
Server version: Apache/2.0.59
Server built: Feb 17 2007 06:24:55
PHP: PHP 5.1.6 (cli) (built: Feb 23 2007 06:56:38)
Zend Engine: v2.1.0
eAccelerator: v0.9.5
Xdebug: v2.0.0
anybody able to verify broken caching? b4 marking this as critical?
Comment #2
ScoutBaker CreditAttribution: ScoutBaker commentedDuplicated on a clean install of D6 HEAD.
Comment #3
ScoutBaker CreditAttribution: ScoutBaker commentedMarked http://drupal.org/node/198670 as a duplicate of this issue.
Comment #4
rkelly CreditAttribution: rkelly commentedThe problem is in the form implementation itself
In system.admin.inc on line 1187:
And then on line 1258:
Both form items are using the same key 'cache'
So come form submit the clear cache button #value is overwriting the cache setting.
Comment #5
catchI think this may have been fixed by: http://drupal.org/cvs?commit=90561
Could you test with a fresh drupal cvs checkout and report back?
Comment #6
hass CreditAttribution: hass commented@Catch: this patch only fixes the CSS and JS compression radio... not the caching mode bullet.
Comment #7
ScoutBaker CreditAttribution: ScoutBaker commented@catch: I also duplicated it last night with a fresh CVS install (#3).
Comment #8
catchQuite trivial, but critical nonetheless.
Comment #9
Gábor HojtsySo does renaming $form['clear_cache']['cache'] to $form['clear_cache']['clear'] solve the problem? Seems to be a logical solution.
Comment #10
catchYes it does.
Comment #11
Gábor HojtsyLook trivial, thanks, committed.
Comment #12
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.