Select a caching mode and click "Save configuration". The next page will say "configuration saved" but none of the caching mode bullets will be selected. Expected result: Current caching mode will be selected to inform the user which mode is in use.

OS: Linux
WS: Apache 1.3
PHP: 4.3
Drupal: 6.0B4
Path: /

CommentFileSizeAuthor
#10 clear.patch949 bytescatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

treksler’s picture

It may be worse than that

it looks like it could be that the bullet doesn't show because cache doesn't get enabled AT ALL
I ran apache bench and results are same no matter what you choose

i get 13-15 requests per second (no matter which option i click)

Drupal 6.0B4
Path:/admin/settings/performance

OS: Red Hat Enterprise Linux AS release 4 (Nahant Update 4)
Server version: Apache/2.0.59
Server built: Feb 17 2007 06:24:55
PHP: PHP 5.1.6 (cli) (built: Feb 23 2007 06:56:38)
Zend Engine: v2.1.0
eAccelerator: v0.9.5
Xdebug: v2.0.0

anybody able to verify broken caching? b4 marking this as critical?

ScoutBaker’s picture

Duplicated on a clean install of D6 HEAD.

ScoutBaker’s picture

Marked http://drupal.org/node/198670 as a duplicate of this issue.

rkelly’s picture

The problem is in the form implementation itself

In system.admin.inc on line 1187:


$form['page_cache']['cache'] = ...

And then on line 1258:


$form['clear_cache']['cache'] = ...

Both form items are using the same key 'cache'
So come form submit the clear cache button #value is overwriting the cache setting.

catch’s picture

Version: 6.0-beta4 » 6.x-dev
Status: Active » Postponed (maintainer needs more info)

I think this may have been fixed by: http://drupal.org/cvs?commit=90561

Could you test with a fresh drupal cvs checkout and report back?

hass’s picture

Status: Postponed (maintainer needs more info) » Active

@Catch: this patch only fixes the CSS and JS compression radio... not the caching mode bullet.

ScoutBaker’s picture

@catch: I also duplicated it last night with a fresh CVS install (#3).

catch’s picture

Priority: Normal » Critical

Quite trivial, but critical nonetheless.

Gábor Hojtsy’s picture

Priority: Critical » Normal

So does renaming $form['clear_cache']['cache'] to $form['clear_cache']['clear'] solve the problem? Seems to be a logical solution.

catch’s picture

Status: Active » Needs review
FileSize
949 bytes

Yes it does.

Gábor Hojtsy’s picture

Status: Needs review » Fixed

Look trivial, thanks, committed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.