Entity Forms in ajax requests don't find the route

Can we test this in any way? :\

Awesome, we have a test!

According to discussion https://github.com/symfony/symfony/issues/4360 SubRequest is always a get request. But preview is a Post request. Does that somehow match the recursion art from #1
(my 2cents and subscribing)

+++ b/core/lib/Drupal/Core/AjaxFormController.php
@@ -0,0 +1,23 @@
+    return new Respnse($form);

Should be Response and it should be USE-ed
(just to let know I read it)

Why isn't the whole form replaced by the response of the preview?
And shouldn't auto-preview be stunned after the result?
(questions from a Router rookie)

http://drupal.org/node/1427826 contains instructions for updating the issue summary with the summary template.

The summary may need to be updated with information from comments.

+++ b/core/lib/Drupal/Core/Controller/HtmlFormController.phpundefined
@@ -64,7 +64,7 @@ public function content(Request $request, $_form) {
     $form = drupal_build_form($form_id, $form_state);
-    return new Response(drupal_render_page($form));
+    return $form;

If you need another reroll, might as well return drupal_build_form($form_id, $form_state)

This looks good to me, but I'd like to have Crell or larowlan RTBC.

+++ b/core/lib/Drupal/Core/HttpKernel.phpundefined
@@ -240,4 +239,30 @@ public function hasEsiSupport()
+   * @param string $controller

string|NULL passing NULL means the sub-request has the enhancers etc run again - we should note this

+++ b/core/lib/Drupal/Core/Controller/AjaxController.phpundefined
@@ -48,6 +48,8 @@ public function content(Request $request, $_content) {
+    // @todo Explain why this is needed.

This is needed because without it this chunk in Drupal\Core\ContentNegotiation leads us to believe that its still an ajax request, even in the sub-request.

if ($request->isXmlHttpRequest()) {
      return 'ajax';
    }

the isXmlHttpRequest() method checks the x-requested-with header. Can we update the comment?

Other than that this looks RTBC to me too and unblocks #1998698: Allow Dialog Controller to work with form/entity form routes

Installs fine but doesn't fix the original issue.
Perhaps missing a call to drupal_render - we're seeing Array instead of the output?

Works as expected™

Overall, you are a HERO. Also just tested and can happily confirm I have my preview back!

Couple of small things, sorry....

+++ b/core/lib/Drupal/Core/HttpKernel.phpundefined
@@ -240,4 +243,30 @@ public function hasEsiSupport()
+   * Setup the request object for a subrequest.

'Sets up the' or 'Creates a'

+++ b/core/lib/Drupal/Core/HttpKernel.phpundefined
@@ -240,4 +243,30 @@ public function hasEsiSupport()
+    // Don't override the controller if it's null.

NULL? Not sure.

+++ b/core/lib/Drupal/Core/HttpKernel.phpundefined
@@ -240,4 +243,30 @@ public function hasEsiSupport()
+    $subrequest = $this->container->get('request')->duplicate($query, NULL, $attributes);
+    return $subrequest;

Can't we just return the result here directly instead of assigning?

+++ b/core/modules/views_ui/lib/Drupal/views_ui/Tests/PreviewTest.phpundefined
@@ -65,4 +65,18 @@ function testPreviewUI() {
+    // Build a list of the result commands keyed by the js commando.

Who is the js commando? :)

re-rolling

Fixes #31

+++ b/core/modules/views_ui/views_ui.theme.incundefined
@@ -461,5 +461,5 @@ function template_preprocess_views_ui_view_preview_section(&$vars) {
-  . '<div class="preview-section">'. $vars['content'] . '</div>';
+  . '<div class="preview-section">'. render($vars['content']) . '</div>';

why not drupal_render() here? is it possible to be empty?

#33: entity-form-routes-1983164.33.patch queued for re-testing.

#37: ajax_entity_routes-1983164-37.patch queued for re-testing.

Committed 7166d89 and pushed to 8.x. Thanks!