Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#33 | 1981316-33.patch | 28.89 KB | swentel |
#33 | interdiff.txt | 706 bytes | swentel |
#31 | 1981316-31.patch | 28.89 KB | pcambra |
#28 | interdiff.txt | 2.95 KB | pcambra |
#28 | interdiff-1.txt | 14.36 KB | pcambra |
Comments
Comment #1
andypostComment #2
andypostMissed one place
Comment #3
andyposttagged for office hours review
Comment #5
andypostFix broken test
Comment #6
swentel CreditAttribution: swentel commentedWe're going todo this in one patch.
Comment #7
swentel CreditAttribution: swentel commentedSo we agreed to this in chunks anyway.
Comment #8
swentel CreditAttribution: swentel commented#5: 1953410-cud-1981316-5.patch queued for re-testing.
Comment #10
swentel CreditAttribution: swentel commentedRerolled
Comment #11
aspilicious CreditAttribution: aspilicious commentedLooking good
Comment #12
aspilicious CreditAttribution: aspilicious commentedback to nr for now, other issue has some interesting comments
Comment #13
aspilicious CreditAttribution: aspilicious commentedSome changes to make use of the objects in stead of the bc layer.
Comment #15
aspilicious CreditAttribution: aspilicious commentedHand edited patches FTW
Comment #17
aspilicious CreditAttribution: aspilicious commentedHmm moe like a reroll. I wonder why there are so many unrelated tests failing...
Comment #19
aspilicious CreditAttribution: aspilicious commentedHopefully green. I had to manually reroll large pieces, hopefully it worked...
Comment #21
aspilicious CreditAttribution: aspilicious commentedComment #23
aspilicious CreditAttribution: aspilicious commented:(
Comment #25
pcambraLet's see what the testbot thinks. Also attaching an interdiff, not sure what chunks of this patch have been actuallly included in the sandbox.
Comment #26
swentel CreditAttribution: swentel commentedThis is looking great too, just one remark, after that it's RTBC.
- edit - RTBC if it's green of course ;)
Let's use $instance->label instead of ->id().
Comment #28
pcambraMoved the field name declaration upper for the link tests and fixed @swentel comment on #26
Comment #29
aspilicious CreditAttribution: aspilicious commentedLooking great thnx for finishing this!
Comment #31
pcambraPhew, core is moving fast, here's a confict fix on #28, no further changes.
Comment #32
andypostRTBC. Only small nitpick, this should be commited to sandbox
let's use label() method to make it easy convert ot NG
Comment #33
swentel CreditAttribution: swentel commentedIndeed. Great work all!
Comment #34
andypost+1 rtbc, @swentel please merge the patch to sandbox
Comment #35
alexpott#33: 1981316-33.patch queued for re-testing.
Comment #37
andypost#33: 1981316-33.patch queued for re-testing.
Comment #38
andypostback to rtbc
Comment #39
alexpottCommitted a6a4adc and pushed to 8.x. Thanks!