Coming from @yched's comment in #1875992-56: Add EntityFormDisplay objects for entity forms:

- field_ui_inactive_message()
Gee, the current code in HEAD is complete nonsense, inactive fields have nothing to do with widgets.
The message should be "%field (@field_name) field requires the %field_type field_type provided by %field_type_module module".
We need the name of the field type and its module in here, not the name of the widget / widget module.

CommentFileSizeAuthor
#1 1974632.patch1.56 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Active » Needs review
FileSize
1974632.patch1.56 KB
swentel’s picture

swentel CreditAttribution: swentel commented

Looks good to me on first glance, do we need tests for this ? :/

amateescu’s picture

amateescu CreditAttribution: amateescu commented

Not sure, if we had a test for every string in the UI.. :P For me this is just a fix-and-forget bug.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community

True, fair enough.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Field API

The last submitted patch, 1974632.patch, failed testing.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs work » Needs review
Issue tags: +Field API

#1: 1974632.patch queued for re-testing.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Reviewed & tested by the community

That was a randon test failure.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.