The current shiv in core seems old.

Sorry I've been out of the loop for a while, not sure about the current process for updating libraries currently in core.

Do we wait till closer to release? or do we just update as they get release?

I know there use to be an issue.

Anyways here a patch to fix this one.

CommentFileSizeAuthor
#1 1974422-1.patch4.47 KBericduran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ericduran’s picture

ericduran CreditAttribution: ericduran commented
Status: Active » Needs review
FileSize
1974422-1.patch4.47 KB

actual patch.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

Works for me, thanks.

Checked that the new github source is the canonical repo for thml5shim source, it is. We should update the url like it's done in the patch.

As for process to updating libraries we don't have one defined. We should update them whenever they get released. The sooner we do the sooner we'll catch problems.

(just a reminder, only IE8 will ever see this file.)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.