"Account administration pages" detection method confusing

The language detection methods are at http://"server"/index.php/admin/config/regional/language/detection

Or, Home -> Menu -> Configuration -> Languages. Then "Detection and Selection Tab".

The text referred to is the 5th item down in the "Detection Method" column, "Account administration pages".

@quietone That is awesome! It will help others get oriented to this issue.

I think it might help, to also get a screenshot (or copy exactly the words) from the account settings page where people (users) can pick their language preference.

Next: a patch to change the words... I'm hoping looking at the user edit page will help us pick some good words.

So accounts have two Language settings
Site language
Administration pages language

In the detection settings,
those are in the table as:

Account
Account site language setting.

Account administration pages
Account administration pages language setting.

They are the two rows that do not have a "Configure" operations. Because it's configured per user in their when editing their account.
Most rows leave out the implied 'language', like: Session language, Browser language

I'm not sure what words to suggest.

Just brainstorming:
1
just account. This makes two rows with the same bold label in the first column and have to read the description to know what it is the difference.
Account
Account site language setting.

Account
Account administration pages language setting.

2
Account setting
Account site language setting.

Account setting for administration pages
Account administration pages language setting.
[that's really long]

3
Account setting
Account site language setting, configured per user.

Account setting for administration pages
Account administration pages language setting, configured per user.
[this made both the short name for the detection method and the description longer...]

---
Nothing really jumps out at me.
There is a setting somewhere that can allow users to pick what theme to use for 'administration pages'.. no. but they can pick for overlay.

also in the account settings (user/1/edit)
Administrative overlay
Use the overlay for administrative pages.

http://drupal.org/project/admin_theme
==========
... anyway, looks like the little word "for" might help
as in
Account setting for administration page
---

@quietone What do you think? You are looking at this page for the first time, right?

I changed the name to:
Account setting for administration pages
I didn't change the description
I don't know if it is the best one but it should be easy to change.

1. instal clean drupal 8
2. under extend, enable language module
3. go to Home -> Menu -> Configuration -> Languages. Then "Detection and Selection Tab", or admin/config/regional/language/detection

these are the steps to reproduce, I'm going to add them to the issue summary

Like 3 in #7, also add the hint that it's per account for the Account method?

I updated the description, like @Gábor Hojtsy said in comment #12.
YesCT thought that it would be good if we changed the description for the account method because its also per account.
I was trying to test it, and I couldn't find the detection and selection tab list thing
I'm not sure why, as I just changed names of things.

Screenshot of patch in #14

This may help folks find the language 'detection and selection'

Patch applied cleanly. Confirmed the changes as in the screenshot from #15. Changing status to 'Reviewed & tested by the community'.

The "language detection" text in #15 actually feels quite long and the description redundant. Might be the best though.

This is more of a departure from the original language. I think the confusion is less with the titles itself but with the variation in sentence/phrase structure of both the titles and the descriptions. This is an attempt at uniformity as well as efficiency (i.e re-titled column header to eliminate repetition).

Screen Shot:

Also, I'm new to contributing, so if I violated any language style guides (I tried to assure that I didn't), apologies in advance!

Patch applied cleanly. Confirmed the labels and descriptions match the ones show in comment #19.

Thanks for updating the patch! Here's some feedback from the sprint.

+++ b/core/modules/language/language.admin.incundefined
@@ -504,7 +504,7 @@ function theme_language_negotiation_configure_form($variables) {
-      array('data' => t('Description')),
+      array('data' => t('Language detection source')),

Changes that aren't relevant to the current issue should be avoided.

+++ b/core/modules/language/language.moduleundefined
@@ -637,7 +637,7 @@ function language_language_negotiation_info() {
-    'description' => t('Language from the URL (Path prefix or domain).'),
+    'description' => t('The path prefix or domain.'),
     'config' => 'admin/config/regional/language/detection/url',

Changes that aren't relevant to the current issue should be avoided.

+++ b/core/modules/language/language.moduleundefined
@@ -650,7 +650,7 @@ function language_language_negotiation_info() {
-    'description' => t('Language from a request/session parameter.'),
+    'description' => t('A request/session parameter.'),
     'config' => 'admin/config/regional/language/detection/session',

Changes that aren't relevant to the current issue should be avoided.

+++ b/core/modules/language/language.moduleundefined
@@ -658,8 +658,8 @@ function language_language_negotiation_info() {
-    'name' => t('Account'),
-    'description' => t('Account site language setting.'),
+    'name' => t('User Account (site setting)'),
+    'description' => t("The language setting for the site in the user's account."),

Talked with Gabor & Cathy... let's use the 'name':

Account preference

The description is good.

+++ b/core/modules/language/language.moduleundefined
@@ -668,7 +668,7 @@ function language_language_negotiation_info() {
-    'description' => t("Language from the browser's language settings."),
+    'description' => t("The browser's language settings."),
     'config' => 'admin/config/regional/language/detection/browser',

Changes that aren't relevant to the current issue should be avoided.

+++ b/core/modules/language/language.moduleundefined
@@ -678,7 +678,7 @@ function language_language_negotiation_info() {
-    'description' => t('Use the detected interface language.'),
+    'description' => t('The detected interface language.'),

Changes that aren't relevant to the current issue should be avoided.

+++ b/core/modules/language/language.moduleundefined
@@ -687,7 +687,7 @@ function language_language_negotiation_info() {
-    'description' => t('Use an already detected language for URLs if none is found.'),
+    'description' => t('An already detected language for URLs if none is found.'),

Changes that aren't relevant to the current issue should be avoided.

+++ b/core/modules/language/language.moduleundefined
@@ -695,8 +695,8 @@ function language_language_negotiation_info() {
-    'name' => t('Account administration pages'),
-    'description' => t('Account administration pages language setting.'),
+    'name' => t('User Account (administration setting)'),
+    'description' => t("The language setting for account administration pages in the user's account."),

Talked with Gabor & Cathy... let's use the 'name':

Account preference for administration pages

The description is good.

If you want to create another issue for cleaning up text/labels not relevant to this issue, you can do that.

Thanks! :)

Created patch based on feedback in comment #22. Attached image of result.

I tested it and I can see the new naming.

However, I suggest further improvements.
As minimal improvement, change 'Account preference' into 'Account preference of site language'
As it is now, it is not clear that it describes the account preference of the site language but could be any account preference. Thus, it does not differentiate from the point 'Account preference for administration pages'.

Further improvement:
To make it more clear, put the word 'language' behind the other elements too.
URL => URL language
Session => Session language
Browser => Browser language
Account preference for administration pages => Account preference for administration pages language

I remember a discussion with Bojan that in the Detection Method we do not add the term "language" as the user is already in a language context and if we add this it's almost the same as the description clolumn. See #1756122: Better Names and Description for Language Negotiations where we already adapted the descriptions and did not touch the Names.

But I agree that 'Account preference' can be confusing, especially because there is another Name with 'Account preference' in it.
So the attached Patch changes 'Account preference' to 'Account preference for site' .

I manually tested and the new wording is there.

Next step: Code review

I did a quick code review. Coding style is good.

I think this is an improvement. It's not perfect yet, BUT we agree that very few people will need to change this from anything other than url detection, so I'm ok with this improvement.

#26: drupal-account_administration_pages_confusing-1974044-26.patch queued for re-testing.

#26: drupal-account_administration_pages_confusing-1974044-26.patch queued for re-testing.

[Note - Schnitzel and I looked at the tests that were failing and they don't have anything to do with this code. He said that if I keep retesting the patch, it might eventually be happy.]

#26: drupal-account_administration_pages_confusing-1974044-26.patch queued for re-testing.

If this fails again, ping rfay on irc, so he can have a look.

Test is green now, moving RTBC again as per YesCT #28

Committed ebfdf7f and pushed to 8.x. Thanks!