Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Lets simplify this text a little, I think the word "skip" is much more accessible than offset so I made it part of the label.
Before
After
Comment | File | Size | Author |
---|---|---|---|
#9 | simplify-pager-options-help-descriptions-1970060-9.patch | 3.27 KB | DrupalChimp |
#6 | simplify,pager.option.descriptions.patch | 3.26 KB | Bojhan |
pager.offset.helptext.patch | 3.31 KB | Bojhan | |
pager-options-after.png | 238.85 KB | Bojhan | |
items-to-display-and-offset-before.png | 268.47 KB | Bojhan |
Comments
Comment #1
oresh CreditAttribution: oresh commentedIn the 'items to skip' you removed word 'field' and replaced with: if this is set to 3.
Can we move the field back, or remove 'this is' word: 'if set to 3' ?
It just sounds strange to me.
Comment #2
Bojhan CreditAttribution: Bojhan commented@oresh We might need to rephrase it altogether. I think its weird to reference "field", as people might think it refers to the concept of "fields" while instead we use it to reference the textfield above.
Comment #3
dawehnerI like the new strings, but feel free to discuss the best solution.
Comment #4
yoroy CreditAttribution: yoroy commentedI think the label is good. For the description maybe:
Comment #5
Bojhan CreditAttribution: Bojhan commented@oresh Lets do this, could you reroll with yoroy his suggestion?
Comment #6
Bojhan CreditAttribution: Bojhan commentedWith the revision suggested by yoroy
Comment #7
dawehnerThis is looking perfect. It's great to cleanup the UI on so many places.
Comment #8
DrupalChimp CreditAttribution: DrupalChimp commentedAgreed, this latest patch works as expected including text in post #4
Comment #9
DrupalChimp CreditAttribution: DrupalChimp commentedActually there was a missing closing bracket in Some.php causing the text to read
now set to
Comment #10
Bojhan CreditAttribution: Bojhan commentedThat sounds ok to me
Comment #11
oresh CreditAttribution: oresh commentedWorks fine for the latest build, no grammar mistakes, description is clear and short.
+1
Comment #12
alexpottCommitted 624947f and pushed to 8.x. Thanks!