Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oresh’s picture

Lets leave the exposed sort order description as is - it definitely explains more to novice users.

For the Ascending and descending - the label feels strange. It reads separately: 'ascending' and 'sort label' and doesn't explain a lot. When I looked on the second image (without looking on the first) i didn't quite understand the meaning. Take into consideration non-english speaking people using this interface (like me :) ) - I didn't get the sense of the label until i scrolled up to view previous image.
Maybe change to 'Label for Ascending order sort' ? That explains more, but takes more space in label. So not sure about it.

Bojhan’s picture

@oresh Agreed, not sure yet how to rephrase it - ideally you want to lead the option with the most important information.

yoroy’s picture

[ ] Include a button to reset all applied exposed filters

For the checkbox '[ ] Expose sort order', why not

[ ] Allow people to choose the sort order

Usually I would try to avoid to have two labels that start with the same words but for the asc/desc maybe:

Label for ascending sort
Label for descending sort
Bojhan’s picture

Issue tags: +Novice

Lets reroll this with yoroy his suggestions.

Bojhan’s picture

Alright, updated :)

exposed-form-cleanup.png

dawehner’s picture

That's looking great.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/ExposedFormPluginBase.phpundefined
@@ -74,22 +72,20 @@ public function buildOptionsForm(&$form, &$form_state) {
       '#description' => t('Allow the user to choose the sort order. If sort order is not exposed, the sort criteria settings for each sort will determine its order.'),

The first part of the description if really redundant (maybe just drop it?). It would be great to keep the second sentence, as people tend to run into problems with the different places were you can configure sorting.

Bojhan’s picture

Assigned: Unassigned » Bojhan

Agreed, I will make a patch.

Bojhan’s picture

Assigned: Bojhan » Unassigned
FileSize
2.83 KB

Done, rerolled with dereine his suggestion

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Great! Thanks for your effort.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed b0e6329 and pushed to 8.x. Thanks

Automatically closed -- issue fixed for 2 weeks with no activity.