Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Removing a bunch of duplication.
Comment | File | Size | Author |
---|---|---|---|
#8 | exposed.form_.reroll.patch | 2.83 KB | Bojhan |
#5 | exposed-form-cleanup.png | 148.27 KB | Bojhan |
#5 | exposed.form_.setting.cleanup.patch | 2.71 KB | Bojhan |
exposed-form-options-sort-cleanup.png | 217.72 KB | Bojhan | |
exposed-forms-cleanup.png | 288.42 KB | Bojhan |
Comments
Comment #1
oresh CreditAttribution: oresh commentedLets leave the exposed sort order description as is - it definitely explains more to novice users.
For the Ascending and descending - the label feels strange. It reads separately: 'ascending' and 'sort label' and doesn't explain a lot. When I looked on the second image (without looking on the first) i didn't quite understand the meaning. Take into consideration non-english speaking people using this interface (like me :) ) - I didn't get the sense of the label until i scrolled up to view previous image.
Maybe change to 'Label for Ascending order sort' ? That explains more, but takes more space in label. So not sure about it.
Comment #2
Bojhan CreditAttribution: Bojhan commented@oresh Agreed, not sure yet how to rephrase it - ideally you want to lead the option with the most important information.
Comment #3
yoroy CreditAttribution: yoroy commented[ ] Include a button to reset all applied exposed filters
For the checkbox '[ ] Expose sort order', why not
[ ] Allow people to choose the sort order
Usually I would try to avoid to have two labels that start with the same words but for the asc/desc maybe:
Comment #4
Bojhan CreditAttribution: Bojhan commentedLets reroll this with yoroy his suggestions.
Comment #5
Bojhan CreditAttribution: Bojhan commentedAlright, updated :)
Comment #6
dawehnerThat's looking great.
The first part of the description if really redundant (maybe just drop it?). It would be great to keep the second sentence, as people tend to run into problems with the different places were you can configure sorting.
Comment #7
Bojhan CreditAttribution: Bojhan commentedAgreed, I will make a patch.
Comment #8
Bojhan CreditAttribution: Bojhan commentedDone, rerolled with dereine his suggestion
Comment #9
dawehnerGreat! Thanks for your effort.
Comment #10
alexpottCommitted b0e6329 and pushed to 8.x. Thanks